Clean Code for bundles/org.eclipse.osgi

[eclipse-equinox-bot]

The following cleanups where applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Make inner classes static where possible
• Replace deprecated calls with inlined content where possible

[github-actions]

Test Results

  669 files  ±0    669 suites  ±0   1h 16m 6s ⏱️ + 2m 33s
2 223 tests ±0  2 176 ✅ ±0   47 💤 ±0  0 ❌ ±0 
6 813 runs  ±0  6 670 ✅ ±0  143 💤 ±0  0 ❌ ±0 

Results for commit 0ba013e. ± Comparison against base commit e35221a.

♻️ This comment has been updated with latest results.

[laeubi]

Cleanup produces a compile error, need to investigate.

[laeubi]

I think this is similar to

• Clean Code for bundles/org.eclipse.equinox.launcher #782

I need to adjust Tycho to pass in the configured toolchain JDKs so we get a real java 8 JVM most likely.

[laeubi]

Tycho change is here:

• Set Toolchan JDKs as JDT JVM installations eclipse-tycho/tycho#4656

[laeubi]

@tjwatson this also cleanups the felix embedded code, we actually have two options here I think

1. I implement some kind of exclusion rules in tycho so we can skip some source path
2. We apply them as is to the codebase

[laeubi]

Also working here now, but waiting for feedback from @tjwatson

[tjwatson]

The changes to org.eclipse packages look fine. We should not change anything to org.osgi or org.apache source. That should be done in the respective projects. Especially for the org.osgi APIs