Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #171: Inconsistent owner document #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #171: Inconsistent owner document #173

wants to merge 1 commit into from

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Feb 26, 2021 •
edited
Loading

there were 2 problems:

  • element attributes were not fully wrapped
  • element.insertBefore returns different instance of the node passed in, so it did not have our user data set

Fixes #171

@lukasj lukasj changed the title #171: Inconsistent owner document Fixes #171: Inconsistent owner document Feb 26, 2021
@sephiroth-j
Copy link
Contributor

sephiroth-j commented Apr 17, 2023 •
edited
Loading

I think this could fix #183 as well.

edit: no, it does not but found the solution while testing it.

This was referenced Apr 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent owner document
2 participants
@lukasj @sephiroth-j