Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defensive null check to stop null pointer exception #1702

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Mustard
Copy link

@Mustard Mustard commented Sep 12, 2022

When joining tables (entities) that have a @customizer (history policy) eclipselink will throw a NullPointerException

I have a simple proof of concept project that demonstrates the issue. Ideally this could be added to the eclipselink project as a test, any help around where to add this test in the project would be appreciated as I couldn't even get the 2.7 branch to build locally and am unfamiliar with the project

This pull request would resolve this issue https://bugs.eclipse.org/bugs/show_bug.cgi?id=526836

A possible other solution / improvement might be to initialise asOfClause in org.eclipse.persistence.internal.expressions.DataExpression such that it is not null in the first place

protected AsOfClause asOfClause = AsOfClause.NO_CLAUSE;

I have agreed to the Eclipse Contributor Agreement https://www.eclipse.org/user/mustard

@lukasj
Copy link
Member

lukasj commented Sep 13, 2022

wrt test - take a look at jpa/eclipselink.jpa.testapps and try to find an existing test this could be added to - jpa.test.advanced or jpa.test.jpql look like good candidates; it does not make much sense to add whole new project for this

@Mustard
Copy link
Author

Mustard commented Nov 22, 2022

Hi @lukasj

Thanks for your help!

Took me a while to get back to it but I have added tests to the pull request, if there is anything else I can do to move this along let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants