fix ERROR on "response-required: false" for modifying commands #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thjaeckle
commented
Dec 9, 2025
thjaeckle
commented
- StatusReply was not handled
* StatusReply was not handled
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where StatusReply messages with response-required: false for modifying commands were causing errors. The fix adds explicit handling for StatusReply success messages in two locations within the persistence supervisor.
Key Changes:
- Added import for
org.apache.pekko.pattern.StatusReply - Added handling for successful
StatusReplymessages inhandleSignalEnforcementResponsemethod - Added handling for successful
StatusReplymessages infilterTargetActorResponseViaEnforcermethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-project-automation
bot
moved this from Waiting for Approval
to Done
in Ditto Planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.