Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove com.google.inject #385

Closed
wants to merge 2 commits into from
Closed

Conversation

stbischof
Copy link
Contributor

I had a look in the dependencies and wondered if this may can be reduced.

this would remove com.google.inject

@waynebeaton
Copy link
Collaborator

While I agree that we should keep dependencies as tight as possible, rearchitecting to avoid using a commonly used and supported dependency injection framework, isn't a goal of the project.

I have considered that we should probably refactor the CLI bits out of the core module along with the Guice dependency, but leave the org.jakarta.inject annotations in core (that is, make core work with any dependency injection implementation).

FWIW, the first implementation actually did use the notion of a context object. I recall that passing the context around was cumbersome, so I investigated various options, including OSGi services and e4 contexts, but decided to go with Guice.

@stbischof
Copy link
Contributor Author

stbischof commented Sep 27, 2024

I did this to understand better what is going on. So okay with closing this.

Even when i would love osgi Services much much more.

Is there a Ticket for the cli extraktion task

@waynebeaton
Copy link
Collaborator

I have considered that we should probably refactor the CLI bits out of the core module along with the Guice dependency, but leave the org.jakarta.inject annotations in core (that is, make core work with any dependency injection implementation).

See #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants