Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OSGi Metadata using bnd-maven-plugin #377

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

stbischof
Copy link
Contributor

@stbischof stbischof commented Sep 26, 2024

see #280

this is the minimal version for osgi metadata. think we should start with that.

@waynebeaton the license year is dynamic calculated. remove for reproducible?

@waynebeaton
Copy link
Collaborator

It is incorrect to set the copyright to the current year.

The copyright should be set to the year that the content was initially created.

The very first bits of IP for this were created in 2019, so that should be the copyright year.

@stbischof
Copy link
Contributor Author

stbischof commented Sep 26, 2024

@waynebeaton updated and thank you for explaining

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stbischof for this.

I have a few remarks below.

core/pom.xml Outdated Show resolved Hide resolved
core/pom.xml Outdated Show resolved Hide resolved
core/pom.xml Outdated Show resolved Hide resolved
core/pom.xml Show resolved Hide resolved
Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you!

@HannesWell HannesWell merged commit a0a61bc into eclipse-dash:master Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants