[OpenShift Integration] Add implementation of getEvents() to avoid busy wait #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Signed-off-by: Angel Misevski <[email protected]>
amisevsk
force-pushed
the
openshift-getevents
branch
from
bc40932 to
0549b9d
Compare
l0rd
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add implementation of getEvents() to OpenShiftConnector. The added method simply discards events as they arrive, but can (and should) be extended to convert OpenShift events into Docker events to be tracked by Che in the future.
Adding the no-op implementation avoids the infinite loop of the previous empty method, lowering CPU usage.
What issues does this PR fix or reference?
Component of #2847.
Changelog
Release Notes