Add OpenShift implementation of getNetworks #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <[email protected]>
|
@l0rd Please give this a test when you have a moment. |
|
Can one of the admins verify this patch? |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2042/ |
l0rd
added
the
kind/task
|
Thank you @amisevsk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds OpenShiftConnector implementation of getNetworks()
What issues does this PR fix or reference?
This is a part of #2847 (replace Docker API calls)
Changelog
Release Notes
N/A (internal changes)
Docs PR
Usage wise nothing is changed (at least it shouldn't be).