-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pair programming plugin #2115
Pair programming plugin #2115
Conversation
Signed-off-by: rnavagamuwa <[email protected]>
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
@rnavagamuwa - this is one of the most impressive GSOC projects I have seen. I hope that you feel that the learning exercise is worth it. Why did you close the PR? We should start gathering a set of requirements on what will be needed to improve in order for this PR to be accepted and placed into the core project. My initial thoughts:
|
@TylerJewell Plugin stopped working when I added some new commits. And also some required classes were deprecated. That's why I closed the PR. I checked that with @vparfonov and he has sent a PR to remove the deprecated tag. After fixing these issues I'll send another PR ASAP. Yes this was a great experience and I learnt a lot. 😄 Regarding your thoughts
|
@rnavagamuwa - you need to prepare yourself that the pull request process can take many weeks. There may be many changes that you have to make along the way to improve the pull requests before it gets accepted. That is part of the learning process. Generally, once you open the PR, you can continue to make commits. You do not need to close the PR for every commit. Keep the PR open and track your changes and keep the discussion moving forward. For a PR to be accepted, it will have to meet coding standards, it will have to be properly documented, you'll have to meet IP requirements & any CQs. This is part of the software development process - and it's a good learning exercise. |
@TylerJewell Yeah , I do understand that it's not a good thing to close and re submit new PRs. Since you have mentioned that the merging process may take a longer time than I expected, thought of sending the PR with the current state. New PR: #2131 😄 |
What does this PR do?
This PR adds the pair programming feature for Eclipse che.
New Behavior
This content may also be included in the release notes.
Tests written?
No
To make the demo up and running:
Create a workspace from a custom stack. Provide the following Dockerfile to your stack:
Start the workspace, Open in IDE
Create a project.
Create a custom command
flux
sudo service rabbitmq-server start && cd /home/user/flux-master/node.server && npm start
Start the flux command
Open a file to edit
Open a new browser windows to the same workspace, open the same file to edit