Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CHE_API_EXTERNAL #15697

Closed
wants to merge 4 commits into from
Closed

Deprecate CHE_API_EXTERNAL #15697

wants to merge 4 commits into from

Conversation

monaka
Copy link
Member

@monaka monaka commented Jan 15, 2020 •
edited
Loading

What does this PR do?

Moves deprecated flags from CHE_API to CHE_API_EXTERNAL.
This is a first step of removing CHE_API_EXTERNAL.

What issues does this PR fix or reference?

This was referenced Jan 15, 2020
Closed
Closed
@monaka monaka requested a review from amisevsk January 17, 2020 01:30
amisevsk
amisevsk reviewed Jan 17, 2020
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on the change, but would like feedback from others on the decision before merging.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jan 17, 2020
@centos-ci
Copy link

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Jul 27, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2020
monaka added 4 commits August 16, 2020 10:25
@monaka
Link CheApiEnvVarProvider to CheApiExternalVarProvider.
5250794 
It should not be linked to CheApiInternalVarProvider. It is used for communication with external web browsers.

Signed-off-by: Masaki Muranaka <[email protected]>
@monaka
Remove the deplicated flag from CheApiEnvVarProvider.
952c9d3 
Actually, `CHE_API` is actively used.

Signed-off-by: Masaki Muranaka <[email protected]>
@monaka
Mark CHE_API_EXTERNAL deprecated.
3a65c35 
Signed-off-by: Masaki Muranaka <[email protected]>
@monaka
Use CHE_API instead of CHE_API_EXTERNAL.
ed88fd9 
As `CHE_API_EXTERNAL` was deplicated.

Signed-off-by: Masaki Muranaka <[email protected]>
@che-bot che-bot closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk left review comments

@ashumilova ashumilova Awaiting requested review from ashumilova

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@metlos metlos Awaiting requested review from metlos

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monaka @centos-ci @che-bot @amisevsk