fix(helm): Keep helm labels sync with che-operator so chectl is able to deploy multiuser without errors

[benoitf]

What does this PR do?

It adds extra labels to helm templates

It is related to documentation for Remote Che as part of EndGame 7.0.0
Else I'm not able to deploy it using chectl (and then write documentation)

$ chectl server:start --platform=k8s --installer=helm --domain=my-server.aws.my-ide.cloud --tls --multiuser
  ✔ ✈️  Kubernetes preflight checklist
    ✔ Verify if kubectl is installed
    ✔ Verify remote kubernetes status...done.
    ✔ Verify domain is set...set to my-serve.my-ide.cloud.
  ✔ 🏃‍  Running Helm to install Che
    ✔ Verify if helm is installed
    ✔ Create Tiller Role Binding...it already exist.
    ✔ Create Tiller Service Account...it already exist.
    ✔ Create Tiller RBAC
    ✔ Create Tiller Service...it already exist.
    ✔ Preparing Che Helm Chart...done.
    ✔ Updating Helm Chart dependencies...done.
    ✔ Deploying Che Helm Chart...done.
  ✔ ✅  Post installation checklist
    ✔ PostgreSQL pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Keycloak pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Che pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Retrieving Che Server URL...https://my-server.my-ide.cloud
    ✔ Che status check
Command server:start has completed successfully.

What issues does this PR fix or reference?

#13637

Change-Id: I9456187a5fb04574c1a9e40e004156a4c45810a9
Signed-off-by: Florent Benoit [email protected]

[l0rd]

I am +1 to include this to 7.0.0 because it is required to address #13801. This issue could be addressed as a chectl fix as well but:

• it's cleaner to make helm and che-operator consistent
• the fix looks pretty safe

[nickboldt]

Will these new labels make it easier or harder to reskin Che 7 as CRW 2 ?

[benoitf]

@NickBolt AFAIK helm is not used for CRW

[nickboldt]

Right, then approved for Che 7 because CRW won't support helm/pure k8s, only openshift.

My thought was that if this makes chectl LESS likely to work for CRW in future, it's a bad thing.

[benoitf]

it's better for chectl (and users) as labels will be the same for operator and helm