Yaml plugin should not need to be run inside its own side car container

[sunix]

Description

At the moment the yaml plugin is using eclipse/che-theia-endpoint-runtime:next but don't really need additional dependencies from the side car container. So it make sense to move that into the Theia-ide container.
https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/redhat/vscode-yaml/0.4.0/meta.yaml#L15

[tsmaeder]

If you have it in the theia image, you can't turn it off. The real solution here would be to implement the idea @benoitf and @tsmaeder had a long time ago to run all plugins that use the same base image in the same container.

[benoitf]

here we could just remove the image in meta.yaml so it goes in theia container (the default)

[amisevsk]

There is an issue with not running plugins in sidecars though, if they require a significant amount of memory. Since the theia container has a relatively tight default memoryLimit, adding any plugins that require memory would also require manually increasing the memory allocated to Theia.

We currently don't have a good flow for accomodating additional plugins in the Theia container (we should e.g. take the memory limit from the plugin and add it to the theia container's default limit).

[gorkem]

@amisevsk although this is correct YAML LS works on a single file so it is relatively nimble. Alternately you can consider running it inside the browser just like it is done for Openshift console.

[amisevsk]

@gorkem I agree here, but created issue #14511 for discussion in any case (I'm guessing the alternative there is what we'll end up doing anyways).

[sunix]

If you have it in the theia image, you can't turn it off. The real solution here would be to implement the idea @benoitf and @tsmaeder had a long time ago to run all plugins that use the same base image in the same container.

turn off -> just remove the plugin from the devfile, no ?

[tsmaeder]

If you mean @benoitf's idea to remove the image from the plugin, yes, that would work. However, I find it unsatisfactory that we have to special-case this: if we implemented container-sharing, we could reap the benefits for every container, not just theia.
I believe our code would be simpler if the host running plugins in the "theia" container were the same as every other host running plugins. Turtles all the way down!

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[tsmaeder]

/remove-lifecycle stale

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[ericwill]

I guess this is still relevant, since vscode-yaml is using the node sidecar these days.