che7 yaml plugin is failing to start

[sunix]

Description

starting a workspace from devfile using the yaml plugin, it is failling to start the yaml plugin with the error

Error - 5:48:19 PM] Starting client failed
Error: spawn ENOMEM
    at ChildProcess.spawn (internal/child_process.js:366:11)
    at spawn (child_process.js:538:9)
    at Object.fork (child_process.js:113:10)
    at Object.fork (/tmp/vscode-unpacked/redhat.vscode-yaml.latest.zdyhmqlakk.redhat.vscode-yaml-0.4.0.vsix/extension/node_modules/vscode-languageclient/lib/utils/electron.js:83:23)
    at Promise (/tmp/vscode-unpacked/redhat.vscode-yaml.latest.zdyhmqlakk.redhat.vscode-yaml-0.4.0.vsix/extension/node_modules/vscode-languageclient/lib/main.js:269:34)
    at new Promise (<anonymous>)
    at LanguageClient.createMessageTransports (/tmp/vscode-unpacked/redhat.vscode-yaml.latest.zdyhmqlakk.redhat.vscode-yaml-0.4.0.vsix/extension/node_modules/vscode-languageclient/lib/main.js:249:24)
    at LanguageClient.createConnection (/tmp/vscode-unpacked/redhat.vscode-yaml.latest.zdyhmqlakk.redhat.vscode-yaml-0.4.0.vsix/extension/node_modules/vscode-languageclient/lib/client.js:1854:21)
    at LanguageClient.resolveConnection (/tmp/vscode-unpacked/redhat.vscode-yaml.latest.zdyhmqlakk.redhat.vscode-yaml-0.4.0.vsix/extension/node_modules/vscode-languageclient/lib/client.js:1697:44)
    at LanguageClient.start (/tmp/vscode-unpacked/redhat.vscode-yaml.latest.zdyhmqlakk.redhat.vscode-yaml-0.4.0.vsix/extension/node_modules/vscode-languageclient/lib/client.js:1628:14)

Reproduction Steps

Start with chectl the devfile:

apiVersion: 1.0.0

metadata:
  name: fail-yaml

projects:

  - name: chectl
    source:
      type: git
      location: 'https://github.com/che-incubator/chectl.git'

components:

  - id: redhat/vscode-yaml/latest
    type: chePlugin

OS and version:
Minikube single-user with chectl (helm)

[monaka]

Just guess but eclipse-che/che-plugin-registry#156 may be related.
Theia itself is enough small within 512MiB. But it will spawn processes via plugins.

[sunix]

not sure as the plugin is running inside the theia container: eclipse-che/che#13555

[monaka]

Referring to the master branch of origin, the language server will be spawn in Theia.

https://github.com/redhat-developer/vscode-yaml/blob/5370d1f3dce905b597c77da692191c7b92b4be61/src/extension.ts#L29-L61

AFAIK, the plugin author can implement to separate the language server from his/her theia plugin.
(I saw such code in the example of Sprotty before.)
But it looks vscode-yaml doesn't.

[tsmaeder]

@monaka if we are really talking about a che 7 plugin, the vscode extension will be run inside a separate sidecar container, so the memory limitations on the theia container will have no impact.
@sunix the default memory settings for the yaml plugin has been updated recently. Can you verify this is fixed now?

[sunix]

fixed

[monaka]

@tsmaeder Thank you for your comment. I see I got misunderstanding after inspecting my workspace containers. And I checked an workspace from the devfile.yaml above boots up fine.