15540 user level tasks #739

tsmaeder · 2020-05-06T12:25:23Z

What does this PR do?

This PR fixes:

Support Che tasks for multi-root workspaces Support Che tasks for multi-root workspaces che#15540
Task: Changing a command in the devfile of an existing workspace is not taken in account Task: Changing a command in the devfile of an existing workspace is not taken in account che#13994

The approach is to not replicate tasks to tasks.json but instead contributing them to the "tasks" key of the user preferences.

Update: switched to replicating the tasks, but to the user level.

tsmaeder · 2020-05-12T10:38:31Z

crw-ci-test

che-bot · 2020-05-12T10:42:22Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

RomanNikitenko · 2020-05-13T12:26:58Z

@tsmaeder
I would like to test your changes, so I need to build the corresponding images, but I found that your fork and branch is outdated

Could you align your branch with master?

che-bot · 2020-05-13T13:20:26Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-05-14T07:16:59Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-05-14T07:35:29Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

tsmaeder · 2020-06-03T13:52:55Z

@RomanNikitenko so what do we need for you to give me a +1 on this PR?

RomanNikitenko · 2020-06-04T12:45:46Z

@RomanNikitenko so what do we need for you to give me a +1 on this PR?

@tsmaeder
The goal of my comments here is: detect and provide you info about regressions using my knowledge about task system.

I reviewed and tested your last changes in upstream, so I think 2 problems from this comment should be fixed now.
I could check it for che tasks on che-theia side, but the corresponding images are outdated at the moment, so I don't have ability to test it again.

I didn't reject your changes, so you can merge this PR any time when you feel it's good enough.

tsmaeder · 2020-06-04T13:11:35Z

At least 1 approving review is required by reviewers with write access

@RomanNikitenko

RomanNikitenko · 2020-06-04T14:22:00Z

@tsmaeder
As I mentioned above the corresponding images are outdated at the moment, so I don't have ability to test it again.

Can you confirm that the following problems were fixed for che tasks:

Che tasks are not displayed in the list for Configure Tasks action
Task system doesn't remember user's choice Never scan the task output

I guess with these changes we still have the following problems:

Running a che task from Workspace panel is not working
Resolving variables for che tasks is not working at editing a configuration (user has open tasks.json file)

The first problem is quite critical from my point of view.
Can we fix at least Running a che task from Workspace panel within current PR?
Did you investigate the problem?

tsmaeder · 2020-06-04T14:56:35Z

crw-ci-test

che-bot · 2020-06-04T15:41:01Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

tsmaeder · 2020-06-10T12:12:19Z

@RomanNikitenko

Running a che task from Workspace panel is not working

I had a (simple) fix for that one, but I guess when my Che on CRC stopped working, I must not have had pushed the fix, so it's lost now. I guess I'll have to redo it, then.

tsmaeder · 2020-06-10T12:13:12Z

* Che tasks are not displayed in the list for Configure Tasks action
* Task system doesn't remember user's choice Never scan the task output

These two are fixed with the latest upstream.

nickboldt · 2020-06-11T14:07:06Z

crw-ci-test

che-bot · 2020-06-11T14:11:52Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Thomas Mäder <[email protected]>

che-bot · 2020-06-16T09:36:14Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-06-16T13:18:46Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Thomas Mäder <[email protected]>

tsmaeder · 2020-06-16T13:57:50Z

@RomanNikitenko finally managed to fix the problem with executing from the "My Workspace" view. If you would be so kind to review that last commit?

che-bot · 2020-06-16T14:11:54Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

tsmaeder · 2020-06-17T08:30:56Z

crw-ci-test

che-bot · 2020-06-17T09:12:40Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:739
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:739

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

RomanNikitenko

Tested after update and can confirm that Running a che task from Workspace panel was fixed within last commit - thanks!

I think the problem
Resolving variables for che tasks is not working at editing a configuration (user has open tasks.json file)
can be fixed in a separate PR.

RomanNikitenko · 2020-06-17T16:26:09Z

btw: it makes sense to provide some changes to the doc https://www.eclipse.org/che/docs/che-7/defining-custom-commands-for-che-theia/ to inform user that che tasks configurations from the devfile are exported to user level tasks.json file (instead of /workspace/.theia directory)

tsmaeder force-pushed the 15540_user_level_tasks branch 2 times, most recently from 878903e to 7937234 Compare May 8, 2020 07:52

tsmaeder requested a review from RomanNikitenko May 8, 2020 11:43

tsmaeder mentioned this pull request May 12, 2020

Fix compilation for theia changes #743

Closed

tsmaeder marked this pull request as ready for review May 12, 2020 08:35

tsmaeder requested review from azatsarynnyy, benoitf, ericwill, svor, vinokurig, vitaliy-guliy and vzhukovs as code owners May 12, 2020 08:35

tsmaeder added kind/enhancement New feature or request status/code-review labels May 12, 2020

azatsarynnyy mentioned this pull request May 12, 2020

Make Che Theia build depending on the previous upstream Theia commit #744

Merged

eclipse-che deleted a comment from che-bot May 13, 2020

tsmaeder force-pushed the 15540_user_level_tasks branch from 22e83cb to 36b3c8d Compare May 14, 2020 07:22

azatsarynnyy mentioned this pull request Jun 2, 2020

Editors Sprint 184 eclipse-che/che#16915

Closed

19 tasks

nickboldt mentioned this pull request Jun 11, 2020

che-theia happy path tests failing since June 8 eclipse-che/che#17144

Closed

3 tasks

Replicate tasks to user settings

5a15ba5

Signed-off-by: Thomas Mäder <[email protected]>

tsmaeder force-pushed the 15540_user_level_tasks branch from b310506 to 5a15ba5 Compare June 16, 2020 09:30

Fix execution of tasks from workspace view

8240d76

Signed-off-by: Thomas Mäder <[email protected]>

tsmaeder force-pushed the 15540_user_level_tasks branch from 1bc1aa9 to 8240d76 Compare June 16, 2020 13:56

RomanNikitenko self-requested a review June 17, 2020 15:29

RomanNikitenko approved these changes Jun 17, 2020

View reviewed changes

RomanNikitenko mentioned this pull request Jun 18, 2020

Che commands binding for multi-root workspaces eclipse-che/che#17191

Closed

tsmaeder merged commit fb23426 into eclipse-che:master Jun 22, 2020

azatsarynnyy mentioned this pull request Jun 22, 2020

Running shell tasks don't execute from tasks panel on the right eclipse-che/che#17202

Closed

22 tasks

l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jul 1, 2020

azatsarynnyy mentioned this pull request Jul 6, 2020

How can I find tasks.json since it's no longer under /projects folder? eclipse-che/che#17335

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

15540 user level tasks #739

15540 user level tasks #739

tsmaeder commented May 6, 2020 •

edited

Loading

tsmaeder commented May 12, 2020

che-bot commented May 12, 2020

RomanNikitenko commented May 13, 2020 •

edited

Loading

che-bot commented May 13, 2020

che-bot commented May 14, 2020

che-bot commented May 14, 2020

tsmaeder commented Jun 3, 2020

RomanNikitenko commented Jun 4, 2020 •

edited

Loading

tsmaeder commented Jun 4, 2020

RomanNikitenko commented Jun 4, 2020

tsmaeder commented Jun 4, 2020

che-bot commented Jun 4, 2020

tsmaeder commented Jun 10, 2020

tsmaeder commented Jun 10, 2020

nickboldt commented Jun 11, 2020

che-bot commented Jun 11, 2020

che-bot commented Jun 16, 2020

che-bot commented Jun 16, 2020

tsmaeder commented Jun 16, 2020

che-bot commented Jun 16, 2020

tsmaeder commented Jun 17, 2020

che-bot commented Jun 17, 2020

RomanNikitenko left a comment

RomanNikitenko commented Jun 17, 2020

15540 user level tasks #739

15540 user level tasks #739

Conversation

tsmaeder commented May 6, 2020 • edited Loading

What does this PR do?

tsmaeder commented May 12, 2020

che-bot commented May 12, 2020

RomanNikitenko commented May 13, 2020 • edited Loading

che-bot commented May 13, 2020

che-bot commented May 14, 2020

che-bot commented May 14, 2020

tsmaeder commented Jun 3, 2020

RomanNikitenko commented Jun 4, 2020 • edited Loading

tsmaeder commented Jun 4, 2020

RomanNikitenko commented Jun 4, 2020

tsmaeder commented Jun 4, 2020

che-bot commented Jun 4, 2020

tsmaeder commented Jun 10, 2020

tsmaeder commented Jun 10, 2020

nickboldt commented Jun 11, 2020

che-bot commented Jun 11, 2020

che-bot commented Jun 16, 2020

che-bot commented Jun 16, 2020

tsmaeder commented Jun 16, 2020

che-bot commented Jun 16, 2020

tsmaeder commented Jun 17, 2020

che-bot commented Jun 17, 2020

RomanNikitenko left a comment

Choose a reason for hiding this comment

RomanNikitenko commented Jun 17, 2020

tsmaeder commented May 6, 2020 •

edited

Loading

RomanNikitenko commented May 13, 2020 •

edited

Loading

RomanNikitenko commented Jun 4, 2020 •

edited

Loading