Devfile to develop VS Code extensions #578

vitaliy-guliy · 2019-12-05T08:41:26Z

What does this PR do?

Adds a devfile to develop VS Code extensions in Che-Theia

What issues does this PR fix or reference?

che-bot · 2019-12-05T09:10:48Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-12-06T00:48:04Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-06T09:51:47Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-06T12:48:07Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-06T13:18:43Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-06T13:26:08Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-06T13:26:37Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-10T08:41:26Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-12-10T08:42:10Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-12-10T09:16:20Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-10T09:17:00Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

devfiles/vscode-extensions.devfile.yaml

sunix · 2019-12-19T09:58:58Z

devfiles/vscode-extensions.devfile.yaml

+          echo -e "\e[32mDone.\e[0m Packaging complete"
+        component: che-dev
+
+  - name: 3. run ... HOSTED Che-Theia + Hello World extension


what if the vscode extension needs to be tested in a sidecar container ? (like most of the vscode extension we have)

I think it's possible. Let's create a dedicated PR with this improvement.

this devfile is doing it: https://github.com/sunix/devfiles/blob/480188119d223d631d17472621e0cef618e22dc9/devfiles/vscode-quarkus/devfile.yaml

I will create another PR with this command.
There is a big difference in use cases, that the workspace doesn't have a special sidecar container.
But I can add a command to launch Che-Theia in theia-ide container and to launch VS Code extension in che-dev container.

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy · 2020-01-14T08:56:02Z

@SkorikSergey this PR should not affect the build and tests. Is it possible to merge?

SkorikSergey · 2020-01-14T09:27:11Z

@SkorikSergey this PR should not affect the build and tests. Is it possible to merge?

Yes. HappyPath test fails according to eclipse-che/che#15586.

vitaliy-guliy · 2020-01-14T09:27:36Z

ci-build

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy · 2020-01-14T14:14:25Z

ci-build

RomanNikitenko · 2020-01-14T18:37:30Z

crw-ci-test

RomanNikitenko · 2020-01-14T18:42:43Z

@vitaliy-guliy
sorry for my comment above, I would like to test - are happy-path-tests working in general?
because for my PR they are still broken...

SkorikSergey · 2020-01-15T14:32:37Z

crw-ci-test

che-bot · 2020-01-15T15:45:29Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Vitaliy Gulyy <[email protected]>

che-bot · 2020-01-21T09:01:53Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

dmytro-ndp · 2020-01-21T09:35:27Z

crw-ci-test

che-bot · 2020-01-21T10:10:23Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:578
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:578

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

vitaliy-guliy requested review from sunix, evidolob, olexii4, AndrienkoAleksandr and mmorhun December 5, 2019 08:41

vitaliy-guliy closed this Dec 10, 2019

vitaliy-guliy force-pushed the vscode-extensions branch from af63b89 to 3ee618e Compare December 10, 2019 08:31

Devfile to develop VS Cde extensions

0bf4e4b

vitaliy-guliy reopened this Dec 10, 2019

vitaliy-guliy marked this pull request as ready for review December 10, 2019 08:34

vitaliy-guliy requested review from l0rd, rhopp and vparfonov as code owners December 10, 2019 08:34

AndrienkoAleksandr approved these changes Dec 18, 2019

View reviewed changes

olexii4 reviewed Dec 18, 2019

View reviewed changes

devfiles/vscode-extensions.devfile.yaml Show resolved Hide resolved

sunix reviewed Dec 19, 2019

View reviewed changes

Merge branch 'master' into vscode-extensions

05d9d69

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy requested review from azatsarynnyy and benoitf as code owners January 13, 2020 15:45

vitaliy-guliy requested review from RomanNikitenko and vzhukovs as code owners January 13, 2020 15:45

Merge branch 'master' into vscode-extensions

874dc58

Signed-off-by: Vitaliy Gulyy <[email protected]>

Merge branch 'master' into vscode-extensions

9d38eac

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy merged commit 77e3a55 into master Jan 23, 2020

vitaliy-guliy deleted the vscode-extensions branch January 23, 2020 11:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Devfile to develop VS Code extensions #578

Devfile to develop VS Code extensions #578

vitaliy-guliy commented Dec 5, 2019

che-bot commented Dec 5, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 10, 2019

che-bot commented Dec 10, 2019

che-bot commented Dec 10, 2019

che-bot commented Dec 10, 2019

sunix Dec 19, 2019

vitaliy-guliy Dec 19, 2019

sunix Jan 16, 2020

vitaliy-guliy Jan 23, 2020

vitaliy-guliy commented Jan 14, 2020

SkorikSergey commented Jan 14, 2020

vitaliy-guliy commented Jan 14, 2020

vitaliy-guliy commented Jan 14, 2020

RomanNikitenko commented Jan 14, 2020

RomanNikitenko commented Jan 14, 2020

SkorikSergey commented Jan 15, 2020

che-bot commented Jan 15, 2020

che-bot commented Jan 21, 2020

dmytro-ndp commented Jan 21, 2020

che-bot commented Jan 21, 2020

Devfile to develop VS Code extensions #578

Devfile to develop VS Code extensions #578

Conversation

vitaliy-guliy commented Dec 5, 2019

What does this PR do?

What issues does this PR fix or reference?

che-bot commented Dec 5, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 6, 2019

che-bot commented Dec 10, 2019

che-bot commented Dec 10, 2019

che-bot commented Dec 10, 2019

che-bot commented Dec 10, 2019

sunix Dec 19, 2019

Choose a reason for hiding this comment

vitaliy-guliy Dec 19, 2019

Choose a reason for hiding this comment

sunix Jan 16, 2020

Choose a reason for hiding this comment

vitaliy-guliy Jan 23, 2020

Choose a reason for hiding this comment

vitaliy-guliy commented Jan 14, 2020

SkorikSergey commented Jan 14, 2020

vitaliy-guliy commented Jan 14, 2020

vitaliy-guliy commented Jan 14, 2020

RomanNikitenko commented Jan 14, 2020

RomanNikitenko commented Jan 14, 2020

SkorikSergey commented Jan 15, 2020

che-bot commented Jan 15, 2020

che-bot commented Jan 21, 2020

dmytro-ndp commented Jan 21, 2020

che-bot commented Jan 21, 2020