Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add devfile and doc for developing of Che Theia remote plugin mechanism #413

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Add devfile and doc for developing of Che Theia remote plugin mechanism #413

merged 4 commits into from
Sep 10, 2019

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Aug 21, 2019

What does this PR do?

Adds devfile and description for Che Theia remote plugin mechanism development.
Actually the devfile has two dev containers: one for Che Theia and one for remote plugin(s) runtime.
Due to development purposes external dependencies for the remote plugin(s) is not supported.

@mmorhun mmorhun self-assigned this Aug 21, 2019
@AndrienkoAleksandr
Copy link
Contributor

I am going to test it :)

@slemeur
Copy link

slemeur commented Aug 22, 2019

Should this be part of the docs? @rkratky

@mmorhun
Copy link
Contributor Author

mmorhun commented Aug 22, 2019 •
edited
Loading

@slemeur I think this is rather part of eclipse-che/che#14126
This describes development flow of remote plugin mechanism and might be useful for contributors and curious users.

@rkratky
Copy link

rkratky commented Aug 22, 2019

@mmorhun we do have 'Contributor Guide' in the docs, and it contains https://www.eclipse.org/che/docs/che-7/developing-che-theia-plug-ins/ (Developing Che-Theia plug-ins). Let me know if you think this should also be included there?

@mmorhun
Copy link
Contributor Author

mmorhun commented Aug 23, 2019

@rkratky this PR suggest a working environment and work flow how to develop Che Theia remote plugin mechanism, not plugins itself. So far we have a set of readme's and I think we should be consistent: keep them as is or duplicate / move all of them to docs.
As for me, we could have links in docs on all of that contribution guides. Just a list. That always give most actual version of contribution flow.

@rkratky
Copy link

rkratky commented Aug 24, 2019

@mmorhun, fair enough. Thanks for the background info.

Could you please look at the docs I linked and suggest a good place where to include the list of links?

@sunix sunix self-requested a review August 24, 2019 15:56
sunix
sunix suggested changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@sunix sunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be part of CONTRIBUTE.md file

AndrienkoAleksandr
AndrienkoAleksandr approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tested

@mmorhun mmorhun force-pushed the devfile-for-remote-plugin-mechanism branch from 64789bf to 5f24d43 Compare August 28, 2019 11:35
@mmorhun
Copy link
Contributor Author

mmorhun commented Aug 28, 2019 •
edited
Loading

@sunix I've moved the doc to the main CONTRIBUTE.md file

sunix
sunix reviewed Aug 28, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
sunix
sunix reviewed Aug 28, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mmorhun mmorhun force-pushed the devfile-for-remote-plugin-mechanism branch from 5f24d43 to 699ca5f Compare August 28, 2019 14:17
sunix
sunix reviewed Sep 2, 2019
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
sunix
sunix suggested changes Sep 2, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mmorhun mmorhun force-pushed the devfile-for-remote-plugin-mechanism branch 2 times, most recently from 8fda9d8 to ffb7258 Compare September 2, 2019 14:08
@mmorhun mmorhun force-pushed the devfile-for-remote-plugin-mechanism branch 3 times, most recently from c05451f to b31b66f Compare September 2, 2019 14:31
@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@eclipse-che eclipse-che deleted a comment from che-bot Sep 4, 2019
@dmytro-ndp
Copy link
Contributor

crw-ci-test

1 similar comment
@dmytro-ndp
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@mmorhun
Copy link
Contributor Author

mmorhun commented Sep 6, 2019

@sunix do you mind to merge this PR?

@sunix
Copy link
Contributor

sunix commented Sep 9, 2019

@mmorhun could you add a command or anything that is making available a ready to use plugin in remote-plugin folder ? rather it is cloning downloading or anything else.

@mmorhun mmorhun force-pushed the devfile-for-remote-plugin-mechanism branch from b31b66f to 0487f26 Compare September 9, 2019 10:00
@mmorhun
Copy link
Contributor Author

mmorhun commented Sep 9, 2019

@sunix I've added a command to generate one

@eclipse-che eclipse-che deleted a comment from che-bot Sep 9, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

sunix
sunix approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@sunix sunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmorhun I made some changes in the TOC if it is fine for you

@che-bot
Copy link
Contributor

che-bot commented Sep 10, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Sep 10, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@mmorhun mmorhun merged commit 8a8ec12 into master Sep 10, 2019
@mmorhun mmorhun deleted the devfile-for-remote-plugin-mechanism branch September 10, 2019 08:58
dmytro-ndp pushed a commit that referenced this pull request Sep 11, 2019
@mmorhun @dmytro-ndp
Add devfile and doc for developing of Che Theia remote plugin mechani…
3e39bf5 
…sm (#413)

* Add devfile and doc for developing of Che Theia remote plugin mechanism
Signed-off-by: Mykola Morhun <[email protected]>

* chore(CONTRIBUTING.md): improve toc and title
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@evidolob evidolob evidolob approved these changes

@sunix sunix sunix approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@mmorhun mmorhun

Labels
kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mmorhun @AndrienkoAleksandr @slemeur @rkratky @che-bot @dmytro-ndp @sunix @evidolob @vitaliy-guliy @akurinnoy