This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Add tests for 'WorkspaceFolderUpdater' #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 63.13% 64.72% +1.58%
==========================================
Files 68 68
Lines 2466 2466
Branches 391 391
==========================================
+ Hits 1557 1596 +39
+ Misses 898 860 -38
+ Partials 11 10 -1
Continue to review full report at Codecov.
|
RomanNikitenko
commented
Mar 1, 2021
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
Signed-off-by: Roman Nikitenko <[email protected]>
RomanNikitenko
force-pushed
the
test-workspace-folder-updater
branch
from
7edc264 to
2504b74
Compare
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
RomanNikitenko
requested review from
ericwill,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
benoitf
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko [email protected]
What does this PR do?
Add tests for 'WorkspaceFolderUpdater'
Screenshot/screencast of this PR
What issues does this PR fix or reference?
It's related to multi-root workspaces support logic eclipse-che/che#17212
How to test this PR?
The tests should be happy.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable