Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Format code. #69

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Format code. #69

merged 1 commit into from
Aug 14, 2019

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

Format code

What issues does this PR fix or reference?

Align code format for eclipse-che/che#14126

Signed-off-by: Oleksandr Andriienko [email protected]

Signed-off-by: Oleksandr Andriienko <[email protected]>
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #69   +/-   ##
======================================
  Coverage    66.6%   66.6%           
======================================
  Files           6       6           
  Lines         569     569           
======================================
  Hits          379     379           
  Misses        165     165           
  Partials       25      25
Impacted Files Coverage Δ
brokers/unified/vscode/broker.go 73.93% <ø> (ø) ⬆️
utils/ioutil.go 28.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4ec9d...5d3c8ce. Read the comment docs.

"log"
"net/http"
Copy link
Contributor

@nickboldt nickboldt Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are there two separate lists here so that log and net/http are listed before the crypto stuff?

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace changes and removal of unneeded formatting (), ;... +1.

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 since golang has a defined enough style, PRs should be checked before merging is approved in the future.

@AndrienkoAleksandr AndrienkoAleksandr merged commit 21952b6 into master Aug 14, 2019
@AndrienkoAleksandr AndrienkoAleksandr deleted the formatCode branch August 14, 2019 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants