Update recipes documentation to add deployments and configmaps #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation for Kubernetes YAML recipes to include deployments and configmap as supported objects. Signed-off-by: Angel Misevski <[email protected]>
ibuziuk
reviewed
Dec 21, 2018
| @@ -156,50 +156,78 @@ The `env_file` Compose option is not supported. Environment variables can be man | |||
| [id="kubernetes-yaml-limitations-and-restrictions"] | |||
| == Kubernetes YAML limitations and restrictions | |||
|
|
|||
| When a workspace is starting, Che creates a https://kubernetes.io/docs/concepts/workloads/pods/pod/[Kubernetes pod]. The following are limitatons and restrictions: | |||
| When a workspace is starting, Che creates various Kubernetes resources to support the IDE and development tools. Workspaces primarily consist of a https://kubernetes.io/docs/concepts/workloads/controllers/deployment/[Deployment] which runs a https://kubernetes.io/docs/concepts/workloads/pods/pod/[Kubernetes pod]. The following are limitatons and restrictions: | |||
There was a problem hiding this comment.
@amisevsk maybe it would be a good idea to add info about replicas limitations that should only be 1 ?
There was a problem hiding this comment.
We could; I didn't add it because I think it's kind of common sense, and the validator will block stack creation, and currently KubernetesDeployments will directly set replicas to 1 if you happen to modify it.
I would rather keep the docs as short as possible and only cover the weird cases we require.
ibuziuk
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update documentation for Kubernetes YAML recipes to include deployments and configmap as supported objects.
Main PR: eclipse-che/che#12203
What issues does this PR fix or reference?
eclipse-che/che#11505 and eclipse-che/che#11507