Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): Add guide on how to test a VS Code extension #1435

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Jul 30, 2020

What does this PR do?

Add a guide to try a VS Code extension in Eclipse Che without forking/building plug-in registry

What issues does this PR fix or reference?

eclipse-che/che#15982
https://issues.redhat.com/browse/RHDEVDOCS-1637

Specify the version of the product this PR applies to.

che 7+

@rkratky
Copy link

rkratky commented Aug 28, 2020

@benoitf, we fixed some lang. (thanks, @boczkowska) and markup issues, and it's ready for merging. Only thing I'm unsure of is the placement in guides. I see you pbbly wanted this in the End-user Guide under Using developer workspaces.

I originally thought it was meant for the Admin Guide because under Customizing devfile and plug-in registries, there's already a Using a VS Code extension in Che. So, I thought the new Testing a VS Code extension in Che belonged with it.

For the time being, I'm leaving it in the Admin Guide, but if you think it would be better in the End-user Guide, I suggest we move both of the VS Code extension topics there.

@rkratky rkratky merged commit 8880a8b into eclipse-che:master Aug 28, 2020
@benoitf
Copy link
Contributor Author

benoitf commented Aug 28, 2020

Hello @rkratky
This is really something for end users and not admins
As here, any user can do that without admin access as it's just a way of providing custom devfiles

@benoitf
Copy link
Contributor Author

benoitf commented Aug 28, 2020

But for example, customizing plugin registry or devfile registry is more an admin stuff so I'm unsure we can move everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants