Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

che #13813: Adding script for the nightly ci build #35

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Jul 12, 2019

What does this PR do?

Adding a separate script for the nightly ci build

What issues does this PR fix or reference?

eclipse-che/che#13813
the second part of the issue - Update che-devfile-registry-periodic CentOS CI job to build the devfile registry image (centos only) and tag it as nightly

@l0rd
Copy link
Contributor

l0rd commented Jul 12, 2019

The script looks identical to the ci one (except for the TAG). Isn't it a way to provide the TAG as a parameter?

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 12, 2019

@l0rd it is possible to do but this will overcomplicate the cico_build.sh in future since I plan to extend the cico_build_nightly.sh for building also https://github.com/eclipse/che-devfile-registry/tree/master/arbitrary-users-patch

In general, supporting cico scripts is not straight so I personally prefer to have distinct scripts for distinct jobs. IMO it will much simplify the support burden since for example for nightly there will be a separate job template in https://github.com/openshiftio/openshiftio-cico-jobs/blob/master/devtools-ci-index.yaml without rhel / centos TARGET (nightly is going to be done only for community)

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 12, 2019

Related cico job PR - openshiftio/openshiftio-cico-jobs#1037

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me to merge

@ibuziuk ibuziuk merged commit f0ebbfa into eclipse-che:master Jul 12, 2019
Ohrimenko1988 added a commit that referenced this pull request Jun 9, 2020
Signed-off-by: Ihor Okhrimenko <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants