che #13813: Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build #31

ibuziuk · 2019-07-11T08:46:47Z

What does this PR do?

Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build

What issues does this PR fix or reference?

Should be merged only once dedicated cico job pr is merged - openshiftio/openshiftio-cico-jobs#1035

ibuziuk · 2019-07-11T08:51:16Z

The only thing I'm not sure about - are we already pushing rhel (not centos) images to quay.io/openshiftio - https://quay.io/repository/openshiftio/che-devfile-registry?tab=tags ?
the image name is che-devfile-registry and I would expect that rhel image name would be rhel-che-devfile-registry

l0rd · 2019-07-11T09:21:45Z

cico_build.sh

  docker build -t ${IMAGE} -f ${DOCKERFILE} .

  TAG=$(echo "$GIT_COMMIT" | cut -c1-"${DEVSHIFT_TAG_LEN}")

  tag_push "${REGISTRY}/openshiftio/$IMAGE:$TAG"
  tag_push "${REGISTRY}/openshiftio/$IMAGE:latest"
-  echo 'CICO: Image pushed, ready to update deployed app'
+  echo "CICO: Images pushed to 'quay.io/openshiftio', ready to update deployed app"


A few suggestions:

I don't think you should login/push to quay.io/eclipse-che if the "$TARGET" == "rhel"

You don't need to the docker build twice

I would avoid tagging the images as latest because that should be done when we do the release of Che every 3 weeks (especially for eclipse-che org)

And do we really need to push centos images to both openshiftio and eclipse-che?

I don't think you should login/push to quay.io/eclipse-che if the "$TARGET" == "rhel"
You don't need to the docker build twice

Maybe I'm missing smth but in the issue description there is - Update che-devfile-registry-master CentOS CI job to push rhel images to quay.io/openshiftio and centos images to quay.io/eclipse-che and my understanding is that master CI job always build 'rhel for now, right?. So, I do not really understand how we can avoid building and pushing images twice if we want CentOS images beeing build as part of the same job

it is actually related to my question in my first question in the PR - #31 (comment)

If what you are saying was true ($TARGET is always "rhel") the script would build rhel images only (the script does only one docker build). But we know that this is not the case because we see that centos images are pushed to the registry right?

So I think that this script is called twice: once with not specific $TARGET and once with TARGET=rhel. And we should double check with SD team but I suspect that we (you and I) do not have the privileges to see the rhel images even if they are pushed in that org.

Another thing I would add in this PR is an update to the README file to use the eclipse-che org images instead of the openshiftio.

So I think that this script is called twice: once with not specific $TARGET and once with TARGET=rhel

@l0rd looks like this is the case (script is called twice with & without the target), because:

for now there is only one job for devfile registry - https://github.com/openshiftio/openshiftio-cico-jobs/blob/master/devtools-ci-index.yaml#L4470

centos images are pushed to https://quay.io/repository/openshiftio/che-devfile-registry?tab=tags

on dsaas devfile-registry is build against openshiftio/rhel-che-devfile-registry images (and yes, we do not have access to https://quay.io/repository/openshiftio/rhel-che-devfile-registry)

Yep.. The script is run twice. Once here:
https://github.com/openshiftio/openshiftio-cico-jobs/blob/master/devtools-ci-index.yaml#L891
And for the second time here (where extra_target=rhel):
https://github.com/openshiftio/openshiftio-cico-jobs/blob/master/devtools-ci-index.yaml#L902

ibuziuk · 2019-07-11T10:40:10Z

@l0rd PR has been updated:

during the build rhel images would be pushed to quay.io/openshiftio/rhel-che-devfile-registry
centos images will be pushed to quay.io/eclipse-che/che-devfile-registry
https://quay.io/repository/openshiftio/che-devfile-registry should be deprecated

I plan to add yet another commit with docs & build instructions but before want to clarify your point around latest tag.
Basically, all the instructions in Readme are currently depended on this tag: e.g.:

if brand-new quay.io/eclipse-che/che-devfile-registry will not contain the latest tag, which one should be used ?

benoitf · 2019-07-11T10:55:27Z

centos images will be pushed to quay.io/eclipse-che/rhel-che-devfile-registry

why name is rhel-something if it's centos ?

ibuziuk · 2019-07-11T10:57:41Z

@benoitf sorry, typo - updated

benoitf · 2019-07-11T11:00:40Z

just a small note, on dockerhub we had eclipse/che-something as org was eclipse.
but on quay.io now with eclipse-che org, do we still che in image name ?

eclipse-che/che-devfile-registry --> eclipse-che/devfile-registry ?

ibuziuk · 2019-07-11T11:09:38Z

@benoitf che-devfile-registry is the repo name so, I personally would expect to have the very same name for docker image, but I do understand your concern

benoitf · 2019-07-11T11:13:47Z

@ibuziuk then it would mean quay org should the same than github org or that we move to eclipse-che org on github as well (it's possible to have its own 'eclipse' org so it could be a good idea as well so we cleary see only repositories linked to che)

ibuziuk · 2019-07-11T11:16:17Z

@benoitf agree, https://quay.io/organization/eclipse would be more logical
@l0rd wdyt ?

rhopp

LGTM

l0rd · 2019-07-11T13:25:28Z

I think eclipse organisation makes more sense as well. But didn't knew if we had the time to move to that org.

For the change to latest I am proposing to:

stop tagging every build as latest (without actually changing the README etc...) => in this PR
start tagging nightlies with the new cron job and update the README etc...to use nigthlies
start tagging releases every 3 weeks as latest

But if you want to stay on the safe side (meaning that we want to make sure that the README will always point to the latest build) you should swap 1. and 2. and do that in separate PRs.

l0rd · 2019-07-11T13:26:27Z

Anyway LGTM for the changes you have made so far

…s images to 'quay.io/eclipse-che' during the CI build Signed-off-by: Ilya Buziuk <[email protected]>

ibuziuk · 2019-07-11T15:24:15Z

I think eclipse organisation makes more sense as well. But didn't knew if we had the time to move to that org.

Indeed looks like we do not have time for moving from one org to anoter and setup ci bots for those

stop tagging every build as latest (without actually changing the README etc...) => in this PR

Done

@l0rd sounds good, so no docs update in this PR. Could you please approve if you are ok to merge it in the current state.

P.S.

So I think that this script is called twice: once with not specific $TARGET and once with TARGET=rhe

checked with SD and indeed ci_cmd command is executed twice (for rhel and centos builds) - https://github.com/openshiftio/openshiftio-cico-jobs/blob/master/devtools-ci-index.yaml#L880-L909

l0rd

LGTM

ibuziuk · 2019-07-11T15:44:35Z

https://quay.io/repository/eclipse-che/che-devfile-registry?tab=tags \o/
prod-preview has been also updated successfully \o/

[CI] Setup user.{email,name}.

Signed-off-by: Ihor Okhrimenko <[email protected]>

…plugin Signed-off-by: Oleksandr Garagatyi <[email protected]>

ibuziuk requested review from l0rd, rhopp, skabashnyuk and vparfonov as code owners July 11, 2019 08:46

ibuziuk mentioned this pull request Jul 11, 2019

Improve che-devfile-registry CI eclipse-che/che#13813

Closed

2 tasks

skabashnyuk approved these changes Jul 11, 2019

View reviewed changes

ibuziuk changed the title ~~rh-che #13813: Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build~~ che #13813: Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build Jul 11, 2019

ibuziuk mentioned this pull request Jul 11, 2019

che #13813 Adding credentials for pushing to the quay.io 'eclipse-che' org openshiftio/openshiftio-cico-jobs#1035

Merged

l0rd reviewed Jul 11, 2019

View reviewed changes

ibuziuk force-pushed the che-13813 branch from 1360d28 to 60707a8 Compare July 11, 2019 10:30

benoitf mentioned this pull request Jul 11, 2019

Use quay.io images in README and other small fixes eclipse-che/che-plugin-registry#182

Merged

rhopp approved these changes Jul 11, 2019

View reviewed changes

rh-che #13813: Pushing rhel images to 'quay.io/openshiftio' and cento…

889ae99

…s images to 'quay.io/eclipse-che' during the CI build Signed-off-by: Ilya Buziuk <[email protected]>

ibuziuk force-pushed the che-13813 branch from 60707a8 to 889ae99 Compare July 11, 2019 15:18

l0rd approved these changes Jul 11, 2019

View reviewed changes

ibuziuk merged commit a09926b into eclipse-che:master Jul 11, 2019

l0rd mentioned this pull request Jul 18, 2019

Improve che-plugin-registry CI eclipse-che/che#13915

Closed

2 tasks

monaka added a commit that referenced this pull request Apr 29, 2020

Merge pull request #31 from PizzaFactory/prp-add-git-config

cb67253

[CI] Setup user.{email,name}.

Ohrimenko1988 added a commit that referenced this pull request Jun 5, 2020

Next try #31

93aa159

Signed-off-by: Ihor Okhrimenko <[email protected]>

sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020

eclipse-che#31: Add an ability to have multiple versions of the same …

50e20b6

…plugin Signed-off-by: Oleksandr Garagatyi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

che #13813: Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build #31

che #13813: Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build #31

ibuziuk commented Jul 11, 2019 •

edited

Loading

ibuziuk commented Jul 11, 2019

l0rd Jul 11, 2019

l0rd Jul 11, 2019

ibuziuk Jul 11, 2019

ibuziuk Jul 11, 2019

l0rd Jul 11, 2019

l0rd Jul 11, 2019

ibuziuk Jul 11, 2019

rhopp Jul 11, 2019

ibuziuk commented Jul 11, 2019 •

edited

Loading

benoitf commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

benoitf commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

benoitf commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

rhopp left a comment

l0rd commented Jul 11, 2019

l0rd commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

l0rd left a comment

ibuziuk commented Jul 11, 2019

che #13813: Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build #31

che #13813: Pushing rhel images to 'quay.io/openshiftio' and centos images to 'quay.io/eclipse-che' during the CI build #31

Conversation

ibuziuk commented Jul 11, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

ibuziuk commented Jul 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ibuziuk commented Jul 11, 2019 • edited Loading

benoitf commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

benoitf commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

benoitf commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

rhopp left a comment

Choose a reason for hiding this comment

l0rd commented Jul 11, 2019

l0rd commented Jul 11, 2019

ibuziuk commented Jul 11, 2019

l0rd left a comment

Choose a reason for hiding this comment

ibuziuk commented Jul 11, 2019

ibuziuk commented Jul 11, 2019 •

edited

Loading

ibuziuk commented Jul 11, 2019 •

edited

Loading