This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Add username field to secure repos #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rwalle61
reviewed
Jun 10, 2020
| @@ -323,6 +323,9 @@ async function constructRepositoryObject(url, description, name, isRepoProtected | |||
| repository = await fetchRepositoryDetails(repository, gitCredentials); | |||
| if (isRepoProtected !== undefined) { | |||
| repository.protected = isRepoProtected; | |||
There was a problem hiding this comment.
fyi protected means "this repository should not be deleted". (It doesn't mean "this repository is secure / requires authentication")
There was a problem hiding this comment.
Ah, thanks! Do we have an alternative? Or do we only need git user/password on authenticated repos?
There was a problem hiding this comment.
Yea we only need to add the authenticated field to the template repo object if the repo is authenticated / requires auth.
So your 'trigger' for adding the field can be just if there are gitCredentials. (Maybe check that if the gitCredentials are invalid we will error before reaching this point)
rwalle61
reviewed
Jun 10, 2020
Signed-off-by: Edward Buckle <[email protected]>
Signed-off-by: Edward Buckle <[email protected]>
hhellyer
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Buckle [email protected]
What type of PR is this ?
What does this PR do ?
For secure template repos, the template object will now contain a field for the user's github username, if available. If not available, the authorization object will be empty:
Which issue(s) does this PR fix ?
#3101
Link to the Codewind repository issue(s) this PR fixes or references:
Does this PR require a documentation change ?
Yes.
Any special notes for your reviewer ?
None.