Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Added Maven Wrapper 3.6.3 #639

Closed
wants to merge 3 commits into from
Closed

Added Maven Wrapper 3.6.3 #639

wants to merge 3 commits into from

Conversation

ohbus
Copy link
Contributor

@ohbus ohbus commented Feb 1, 2021

Added Maven Wrapper

These files are from Maven wrapper. It works similarly to the Gradle wrapper.

This allows you to run the Maven project without having Maven installed and present on the path. It downloads the correct Maven version if it's not found (as far as I know by default in your user home directory).

The mvnw file is for Linux (bash) and the mvnw.cmd is for the Windows environment.

Should fix #579

  • Maven Binary Version 3.6.3
  • Maven Wrapper Version 0.5.6

@ohbus ohbus marked this pull request as ready for review February 1, 2021 10:35
@neubs-bsi
Copy link
Contributor

Hello @ohbus ,
thanks for your contribution.
As you might have seen in some places, we have a contribution guideline. Your commit messages do not describe why the changes are necessary.
For example: 295d1ca
refactored PR build behavior -> why is that better than before or why is it necessary.

Additionally I would like to ask you, to use the pull request template that comes with this repository. It should have automatically been there when you filed this PR.

@ohbus
Copy link
Contributor Author

ohbus commented Feb 13, 2021

Hi @neubs-bsi, as I have linked the corresponding Issue against this Pull request I did not follow the template.

I apologize for this and would like to amend the necessary changes.

Thanks.

@neubs-bsi
Copy link
Contributor

Hello @ohbus

We don't want merge commits in a PR, rather it's preferred to rebase master on the branch of the PR.
Additionally, you have not re-written the commit messages. It is still not obvious why the changes would be better than the way it was before. Please amend the commit messages.

Signed-off-by: Subhrodip Mohanta <[email protected]>
Signed-off-by: Subhrodip Mohanta <[email protected]>
@ohbus
Copy link
Contributor Author

ohbus commented Mar 3, 2021

@neubs-bsi done with your requests

@ohbus ohbus closed this by deleting the head repository Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using the Maven wrapper
2 participants