Sort campCollaboration- & MaterialList-List #5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattmann
force-pushed
the
feature/list-orders
branch
from
ff170f8
to
840f05c
Compare
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
BacLuc
approved these changes
Jul 20, 2024
| ...keyBy(this.camp.campCollaborations().items, '_meta.self'), | ||
| ...keyBy( | ||
| sortBy(this.camp.campCollaborations().items, (u) => | ||
| campCollaborationDisplayName(u, this.$tc.bind(this)).toLowerCase() |
There was a problem hiding this comment.
So that sorting is alphabetical regardless of capitalization.
manuelmeister
approved these changes
Aug 6, 2024
Comment on lines
+68
to
+85
| return sortBy( | ||
| this.campCollaborations.items | ||
| .filter((cc) => { | ||
| return ( | ||
| cc.status !== 'inactive' || | ||
| this.currentCampCollaborationIRIs.includes(cc._meta.self) | ||
| ) | ||
| }) | ||
| .map((value) => { | ||
| // following structure is defined by vuetify v-select items property | ||
| return { | ||
| value: value._meta.self, | ||
| campCollaboration: value, | ||
| text: campCollaborationDisplayName(value, this.$tc.bind(this)), | ||
| } | ||
| }), | ||
| (value) => value.text.toLowerCase() | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5484
In ScheduleEntry-View, ResponsibleUser List is sorted alphabetically.
In Material-View, MaterialList is sorted
Non-User before User-Lists
then alphabetically