Python 3 support #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes warning: afs/_pts.pyx:115:8: Unreachable code warning: afs/_pts.pyx:130:8: Unreachable code Signed-off-by: Anders Kaseorg <[email protected]>
Fixes warning: afs/_util.pyx:15:5: Function 'pioctl_read' previously declared as 'private' warning: afs/_util.pyx:29:5: Function 'pioctl_write' previously declared as 'private' Signed-off-by: Anders Kaseorg <[email protected]>
Previously, PTS.__cinit__ would leave sc uninitialized when passed an
invalid negative sec argument.
Fixes
afs/_pts.c: In function ‘__pyx_pf_3afs_4_pts_3PTS___cinit__’:
afs/_pts.c:2999:56: warning: ‘__pyx_v_sc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
(__pyx_v_serverconns[__pyx_v_i]) = rx_NewConnection((__pyx_v_info.hostAddr[__pyx_v_i]).sin_addr.s_addr, (__pyx_v_info.hostAddr[__pyx_v_i]).sin_port, PRSRV, __pyx_v_sc, __pyx_t_9);
^
Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths are handled using Python 3's standard "surrogateescape" encoding. All other strings are handled as pure ASCII.
This also supports modern OpenAFS where some functions were split out into new libraries.
Finally, I included Anders's old commits to remove compiler warnings.