Remove debug artifacts and fix code

PHPStan yells at `Attribute class INVALID\NOT\FOUND\ATTRIBUTE does not exist.`
ebln · Jun 7, 2024 · 1d4e513 · 1d4e513
1 parent fbcb705
commit 1d4e513
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 14 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -6,12 +6,3 @@ parameters:
     paths:
         - src
         - tests
-
-    excludePaths:
-        analyseAndScan:
-            - tests/data/*
-            - tests/dataAttrib/*
-            - tests/dataMixed/*
-
-rules:
-    - \Ebln\PHPStan\EnforceFactory\ForceFactoryRule
diff --git a/tests/dataAttrib/LoopholeFactory.php b/tests/dataAttrib/LoopholeFactory.php
@@ -6,14 +6,14 @@
 
 class LoopholeFactory
 {
-    public function variableUninferable(bool $toggle): void
+    public function variableUninferable(bool $toggle): object
     {
         if ($toggle) {
             $class = '\Test\Ebln\PHPStan\EnforceFactory\dataAttrib\code\LoopholeProduct';
         } else {
             $class = 'Hello world-' . random_int(10, 99);
         }
 
-        $new = new $class();
+        return new $class();
     }
 }
diff --git a/tests/dataAttrib/LoopholeInvoker.php b/tests/dataAttrib/LoopholeInvoker.php
@@ -20,8 +20,8 @@ public function expectedFailingLoophole(): object
         return $loophole;
     }
 
-    public function expectedMissingClass()
+    public function expectedMissingClass(): void
     {
-        return $this->loopholeFactory->variableUninferable(false);
+        $this->loopholeFactory->variableUninferable(false);
     }
 }
diff --git a/tests/dataAttrib/code/IndependentForcedFactoryProduct.php b/tests/dataAttrib/code/IndependentForcedFactoryProduct.php
@@ -7,7 +7,6 @@
 use Test\Ebln\PHPStan\EnforceFactory\dataAttrib\IndependentFactory;
 
 #[\Ebln\Attrib\ForceFactory(IndependentFactory::class)]
-#[\INVALID\NOT\FOUND\ATTRIBUTE(IndependentFactory::class)]
 class IndependentForcedFactoryProduct
 {
 }