Introduce ProfilesMixin and clean up some of Profiles.vue's code #1359
Conversation
|
Draft, no build errors, but modal functionality isn't working. |
| </script> | ||
| <template> | ||
| <!-- Profile import / update selection modal --> | ||
| <ModalCard v-if="isOpen && activeStep === 'IMPORT_UPDATE_SELECTION'" :is-active="isOpen" @close-modal="closeModal"> |
There was a problem hiding this comment.
I would consider having just one ModalCard component, and having each step as a <template v-if="activeStep === ...>. Would be cleaner IMO. That being said, IDK if it will work nicely with what ModalCard expects it's contents to be.
VilppeRiskidev
force-pushed
the
import-profile-modal-refactor
branch
2 times, most recently
from
2642140
to
638ee31
Compare
|
More work done, importing works, updating doesn't, I'll try to fix that next. Didn't move anything to vuex yet. |
VilppeRiskidev
force-pushed
the
import-profile-modal-refactor
branch
from
638ee31
to
0a2652f
Compare
|
Finally got the importing working also, up next I'll continue testing/fixing. After testing seems ok, I'll move stuff to vuex and to mixins, After that I'll remove the old code. |
| // When updating: | ||
| // 1. Reads and parses the mods to be installed | ||
| // 2. Creates an EventListener which gets triggered after the user has selected the old profile to be updated. The callback then: | ||
| // 1. Creates a temporary profile (called _profile_update) |
There was a problem hiding this comment.
Actually to me it seems more like:
- Deletes the temporary profile (called _profile_update) if it exists (leftover from previous failed run or something like that?)
- Downloads (and extracts) the mods to temporary profile
- Deletes the old profile (including the folder on disk)
- Renames temporary profile to the chosen profile's name
Which makes more sense, since I assume the point of having the temp folder is to not lose the original profile if something goes wrong when downloading/extracting the mods.
VilppeRiskidev
force-pushed
the
import-profile-modal-refactor
branch
from
351460c
to
a7fa19f
Compare
There was a problem hiding this comment.
- Please split this into two separate PRs
- The first one should introduce the mixin and move the methods from the modal components into the mixin
- I was thinking that the mixin would be for the modals, not for the Profiles.vue. It might make sense to use the mixin for Profiles.vue too, but it's hard for me to judge it currently due to the scope of this PR
- The second PR should be about separating the import modal from Profiles
- This can add additional methods to the mixin if it makes sense
VilppeRiskidev
force-pushed
the
import-profile-modal-refactor
branch
5 times, most recently
from
6cd313b
to
e0d1e5a
Compare
VilppeRiskidev
changed the title
| return sanitize(nameToSanitize); | ||
| } | ||
|
|
||
| async setSelectedProfile(profileName: string, prewarmCache = true) { |
There was a problem hiding this comment.
As far as I can tell, even when checking the next PR in the stack, this method and all below it in this file, are only used by Profiles.vue. If this is the case, what is the rationale of moving them into the mixin? Seems we would get the cons (having the code split into multiple places) without the pros (code reusability).
This also applies to appName getter.
VilppeRiskidev
force-pushed
the
import-profile-modal-refactor
branch
from
e0d1e5a
to
97a1264
Compare
No description provided.