Skip to content

Conversation

@strengejacke
Copy link
Member

Fixes #861

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR addresses a bug where the digits option didn't affect AIC/BIC display. It refactors the print.performance_model method to R/print-methods.R and updates documentation for display() to introduce an ic_digits argument, allowing explicit control over AIC/BIC decimal places. An example demonstrating its usage is also added.

Highlights

  • Intent: This pull request aims to fix an issue where the digits display option was not correctly applied to Information Criteria (AIC/BIC) values when using the display() function. The fix introduces a dedicated ic_digits argument to control the precision of these values.
  • Changes: The primary change involves refactoring the print.performance_model S3 method by moving its definition from R/model_performance.R to R/print-methods.R. This change centralizes print-related methods. Additionally, the documentation for display.performance_model and print.performance_model (now linked via @rdname) has been updated to clarify that the ... argument can accept ic_digits to specify the number of decimal places for AIC/BIC. A new example display(mp, digits = 3, ic_digits = 4) has been added to demonstrate this functionality.
  • Reviewer Activity: No specific reviewer activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Overall, this pull request effectively addresses the issue of controlling the number of digits for AIC/BIC values by improving the documentation and providing a clear example. The refactoring of print.performance_model into its own R/print-methods.R file is a good move for better code organization and maintainability. I have one suggestion to improve the clarity of the newly moved function.

@strengejacke strengejacke merged commit 3aa80c7 into main Oct 8, 2025
20 of 21 checks passed
@strengejacke strengejacke deleted the strengejacke/issue861 branch October 8, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

digits display option doesn't get passed to AIC/BIC

2 participants