Style with air #862
Style with air #862
Conversation
Summary of ChangesHello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, titled 'Style with air', is a comprehensive code formatting and styling update. It introduces consistent whitespace and line breaks across numerous R files to improve readability. Key changes include reformatting function arguments, breaking down long function calls and complex logical conditions, and adjusting the layout of various code blocks. No functional changes or new features are introduced; the focus is entirely on code aesthetics and maintainability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a lot of stylistic changes, presumably from an automated tool like styler. While most changes improve readability by breaking long lines, there are several inconsistencies where function definitions or calls are collapsed into a single line, contrasting with the general trend of expanding them. I've pointed out these inconsistencies to help maintain a uniform code style across the project.
| method = "zscore_robust", | ||
| threshold = NULL, | ||
| ...) { | ||
| check_outliers.numeric <- function(x, method = "zscore_robust", threshold = NULL, ...) { |
There was a problem hiding this comment.
This function definition has been collapsed to a single line, which is inconsistent with the multi-line formatting applied to other function definitions in this pull request (e.g., check_outliers.data.frame on line 1029). To maintain a consistent style, please consider expanding it.
This inconsistency is also present for other function definitions in this file, such as:
check_outliers.gls.check_outliers_iqr.check_outliers_ci.check_outliers_cook.check_outliers_ics.check_outliers_optics.check_outliers_lof
check_outliers.numeric <- function(
x,
method = "zscore_robust",
threshold = NULL,
...
) {| metrics = "all", | ||
| verbose = TRUE, | ||
| ...) { | ||
| model_performance.mixor <- function(model, metrics = "all", verbose = TRUE, ...) { |
There was a problem hiding this comment.
This function definition has been collapsed to a single line, which is inconsistent with the multi-line formatting applied to other function definitions in this pull request (e.g., model_performance.merMod on line 42). To maintain a consistent style, please consider expanding it.
model_performance.mixor <- function(
model,
metrics = "all",
verbose = TRUE,
...
) {| ci = 0.95, | ||
| method = "Herron", | ||
| verbose = TRUE) { | ||
| performance_pcp <- function(model, ci = 0.95, method = "Herron", verbose = TRUE) { |
There was a problem hiding this comment.
This function definition has been collapsed to a single line, which is inconsistent with the multi-line formatting applied to other function definitions in this pull request (e.g., performance_accuracy on line 38). To maintain a consistent style, please consider expanding it.
performance_pcp <- function(
model,
ci = 0.95,
method = "Herron",
verbose = TRUE
) {| data = dat, | ||
| weights = tot | ||
| ) | ||
| mod <- glm(prop ~ x1, family = binomial, data = dat, weights = tot) |
There was a problem hiding this comment.
This function call has been collapsed to a single line, which is inconsistent with the multi-line formatting applied to other function calls in this pull request (e.g., the binned_residuals call on line 34). To maintain a consistent style, please consider expanding it.
mod <- glm(
prop ~ x1,
family = binomial,
data = dat,
weights = tot
)| family = binomial, | ||
| data = dat | ||
| ) | ||
| mod1 <- glm(cbind(suc, tot - suc) ~ 1, family = binomial, data = dat) |
There was a problem hiding this comment.
This function call has been collapsed to a single line, which is inconsistent with the multi-line formatting applied to other function calls in this pull request. To maintain a consistent style, please consider expanding it.
This also applies to mod2, mod3, and mod4 in this file.
mod1 <- glm(
cbind(suc, tot - suc) ~ 1,
family = binomial,
data = dat
)
No description provided.