Skip to content

Commit

Permalink
Refactor AmazonShipping options and formatting
Browse files Browse the repository at this point in the history
- Adjusted spacing in the AddAmazonShippingClient method for consistency.
- Removed 'required' keyword from ClientId, ClientSecret, and RefreshToken properties in AmazonShippingApiOptions, making them optional.
- Assigned default values of string.Empty to ClientId, ClientSecret, and RefreshToken.
  • Loading branch information
Brandon Moffett committed Dec 14, 2024
1 parent f8ede64 commit acd3024
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static IServiceCollection AddAmazonShippingClient(
string sectionName = nameof(AmazonShippingApiOptions),
Action<AmazonShippingApiOptions, IServiceProvider>? configure = null)
{
//services.AddChangeTokenOptions<AmazonShippingApiOptions>(sectionName, null, (options, config) => configure?.Invoke(options, config));
services.AddChangeTokenOptions<AmazonShippingApiOptions>(sectionName, null, (options, config) => configure?.Invoke(options,config));

Check warning on line 15 in src/EasyKeys.Shipping.Amazon.Abstractions/DependencyInjection/AmazonShippingServiceCollectionExtensions.cs

View workflow job for this annotation

GitHub Actions / build

services.AddSingleton<IAmazonApiAuthenticatorService, AmazonApiAuthenticatorService>();
// add generated api clients

Check warning on line 17 in src/EasyKeys.Shipping.Amazon.Abstractions/DependencyInjection/AmazonShippingServiceCollectionExtensions.cs

View workflow job for this annotation

GitHub Actions / build

// services.AddHttpClient<AuthorizationApi>();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace EasyKeys.Shipping.Amazon.Abstractions.Options;

namespace EasyKeys.Shipping.Amazon.Abstractions.Options;
public class AmazonShippingApiOptions
{
required public string ClientId { get; set; }
public string ClientId { get; set; } = string.Empty;

required public string ClientSecret { get; set; }
required public string RefreshToken { get; set; }
public string ClientSecret { get; set; } = string.Empty;

public string RefreshToken { get; set; } = string.Empty;
}

0 comments on commit acd3024

Please sign in to comment.