Fix handling of priorities and path normalisation in LMod $MODULEPATH and show warning on failed prepending
#5030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lmod ignores if a path exists so we should be able to do the same
Introduce _set_module_path which correctly handles empty paths and empty lists with proper logging
When adding a path with a priority which is already at the front we need to run the module command anyway to apply the priority or it can be overriden by subsequent additions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup based on #3636
During that I found 2 bugs in our current LMod ModulesTool implementation:
add_module_paththe paths must be normalized to compare against a normalized path$MODULEPATHwhich can cause other paths to take priorityAdditionally I introduced a warning when prepending a module path that doesn't end up at the front as the name suggested. I limit this to cases without any priorities (in effect or new) or when using a new priority