Skip to content

Show directory that was searched for source directory in Clang easyblock #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Show directory that was searched for source directory in Clang easyblock #3960

wants to merge 1 commit into from

Conversation

@Flamefire
Copy link
Contributor

(created using eb --new-pr)

@Flamefire
Copy link
Contributor Author

Flamefire commented Oct 15, 2025 •
edited
Loading

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
i8019 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 580.65.06, Python 3.9.21
See https://gist.github.com/Flamefire/3591197f273c26dea82d85cb9b5bcb22 for a full test report.

This shows the change in a purposely failing build

== 2025-10-15 16:17:37,723 build_log.py:226 ERROR EasyBuild encountered an error (at easybuild/base/exceptions.py:126 in init): Failed to find exactly one source directory in /dev/shm/s3248973-EasyBuild1947937/Clang/13.0.1/GCCcore-11.3.0/libunwind-13.0.1.src for pattern ['compiler-rt-*']: [] (at easybuild/easyblocks/clang.py:261 in find_source_dir)

boegel
boegel requested changes Oct 22, 2025
View reviewed changes
easybuild/easyblocks/c/clang.py
raise EasyBuildError("Failed to find exactly one source directory for pattern %s: %s", globpatterns,
glob_src_dirs)
raise EasyBuildError("Failed to find exactly one source directory in %s for pattern %s: %s",
os.getcwd(), globpatterns, glob_src_dirs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about this directory potentially not existing?

If so, we can use os.getenv('PWD') instead of os.getcwd()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how it is possible for this directory to get removed while we are in the top of the extract step

@boegel boegel added this to the next release (5.2.0?) milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

next release (5.2.0?)

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel