Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"tiny-invariant": "^1.2.0",
"tsdx": "^0.14.1",
"tslib": "^2.4.0",
"typescript": "^4.7.4"
"typescript": "5.7.3"
},
"dependencies": {
"flairup": "1.0.0"
Expand Down
2 changes: 1 addition & 1 deletion src/Stylesheet/stylesheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const commonInteractionStyles = stylesheet.create({
}
});

export function darkMode(key: string, value: Styles) {
export function darkMode(key: string, value: Styles): Record<string, Record<string, Styles>> {
return {
'.epr-dark-theme': {
[key]: value
Expand Down
14 changes: 4 additions & 10 deletions src/components/body/EmojiCategory.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@ import {
commonStyles,
stylesheet
} from '../../Stylesheet/stylesheet';
import {
CategoryConfig,
categoryFromCategoryConfig,
categoryNameFromCategoryConfig
} from '../../config/categoryConfig';
import { CategoryConfig } from '../../config/categoryConfig';

type Props = Readonly<{
categoryConfig: CategoryConfig;
Expand All @@ -26,9 +22,7 @@ export function EmojiCategory({
hidden,
hiddenOnSearch
}: Props) {
const category = categoryFromCategoryConfig(categoryConfig);
const categoryName = categoryNameFromCategoryConfig(categoryConfig);

const { category, name } = categoryConfig;
return (
<li
className={cx(
Expand All @@ -37,9 +31,9 @@ export function EmojiCategory({
hiddenOnSearch && commonInteractionStyles.hiddenOnSearch
)}
data-name={category}
aria-label={categoryName}
aria-label={name}
>
<h2 className={cx(styles.label)}>{categoryName}</h2>
<h2 className={cx(styles.label)}>{name}</h2>
<div className={cx(styles.categoryContent)}>{children}</div>
</li>
);
Expand Down
11 changes: 5 additions & 6 deletions src/components/body/EmojiList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ import * as React from 'react';
import { ClassNames } from '../../DomUtils/classNames';
import { stylesheet } from '../../Stylesheet/stylesheet';
import {
Categories,
CategoryConfig,
categoryFromCategoryConfig
Category,
CategoryConfig
} from '../../config/categoryConfig';
import {
useCategoriesConfig,
Expand Down Expand Up @@ -34,9 +33,9 @@ export function EmojiList() {
return (
<ul className={cx(styles.emojiList)}>
{categories.map(categoryConfig => {
const category = categoryFromCategoryConfig(categoryConfig);
const category = categoryConfig.category

if (category === Categories.SUGGESTED) {
if (category === 'suggested') {
return <Suggested key={category} categoryConfig={categoryConfig} />;
}

Expand All @@ -59,7 +58,7 @@ function RenderCategory({
categoryConfig,
renderdCategoriesCountRef
}: {
category: Categories;
category: Category;
categoryConfig: CategoryConfig;
renderdCategoriesCountRef: React.MutableRefObject<number>;
}) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/emoji/BaseEmojiProps.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { CustomEmoji } from '../../config/customEmojiConfig';
import { DataEmoji } from '../../dataUtils/DataTypes';
import { EmojiStyle } from '../../types/exposedTypes';
import { EmojiStyle } from '../../types/public';

export type BaseEmojiProps = {
emoji?: DataEmoji | CustomEmoji;
Expand Down
2 changes: 1 addition & 1 deletion src/components/emoji/EmojiImg.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { cx } from 'flairup';
import * as React from 'react';

import { stylesheet } from '../../Stylesheet/stylesheet';
import { EmojiStyle } from '../../types/exposedTypes';
import { EmojiStyle } from '../../types/public';

import { emojiStyles } from './emojiStyles';

Expand Down
5 changes: 3 additions & 2 deletions src/components/emoji/ExportedEmoji.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import * as React from 'react';

import { EmojiStyle } from '../../types/exposedTypes';

import { EmojiStyle } from '../../types/public';

import { GetEmojiUrl } from './BaseEmojiProps';
import { ViewOnlyEmoji } from './ViewOnlyEmoji';

export function ExportedEmoji({
unified,
size = 32,
emojiStyle = EmojiStyle.APPLE,
emojiStyle = 'apple',
lazyLoad = false,
getEmojiUrl,
emojiUrl
Expand Down
5 changes: 2 additions & 3 deletions src/components/emoji/ViewOnlyEmoji.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
emojiUrlByUnified
} from '../../dataUtils/emojiSelectors';
import { isCustomEmoji } from '../../typeRefinements/typeRefinements';
import { EmojiStyle } from '../../types/exposedTypes';
import { useEmojisThatFailedToLoadState } from '../context/PickerContext';

import { BaseEmojiProps } from './BaseEmojiProps';
Expand Down Expand Up @@ -40,7 +39,7 @@ export function ViewOnlyEmoji({
<EmojiImg
style={style}
emojiName={unified}
emojiStyle={EmojiStyle.NATIVE}
emojiStyle={'native'}
lazyLoad={lazyLoad}
imgUrl={emojiToRender.imgUrl}
onError={onError}
Expand All @@ -51,7 +50,7 @@ export function ViewOnlyEmoji({

return (
<>
{emojiStyle === EmojiStyle.NATIVE ? (
{emojiStyle === 'native' ? (
<NativeEmoji unified={unified} style={style} className={className} />
) : (
<EmojiImg
Expand Down
5 changes: 2 additions & 3 deletions src/components/main/PickerMain.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
import useIsSearchMode from '../../hooks/useIsSearchMode';
import { useKeyboardNavigation } from '../../hooks/useKeyboardNavigation';
import { useOnFocus } from '../../hooks/useOnFocus';
import { Theme } from '../../types/exposedTypes';
import { usePickerMainRef } from '../context/ElementRefContext';
import {
PickerContextProvider,
Expand Down Expand Up @@ -56,8 +55,8 @@ function PickerRootElement({ children }: RootProps) {
className={cx(
styles.main,
styles.baseVariables,
theme === Theme.DARK && styles.darkTheme,
theme === Theme.AUTO && styles.autoThemeDark,
theme === 'dark' && styles.darkTheme,
theme === 'auto' && styles.autoThemeDark,
{
[ClassNames.searchActive]: searchModeActive
},
Expand Down
7 changes: 2 additions & 5 deletions src/components/navigation/CategoryButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ import {
darkMode,
stylesheet
} from '../../Stylesheet/stylesheet';
import {
CategoryConfig,
categoryNameFromCategoryConfig
} from '../../config/categoryConfig';
import { CategoryConfig } from '../../config/categoryConfig';
import { Button } from '../atoms/Button';

import SVGNavigation from './svg/CategoryNav.svg';
Expand Down Expand Up @@ -42,7 +39,7 @@ export function CategoryButton({
}
)}
onClick={onClick}
aria-label={categoryNameFromCategoryConfig(categoryConfig)}
aria-label={categoryConfig.name}
aria-selected={isActiveCategory}
role="tab"
aria-controls="epr-category-nav-id"
Expand Down
11 changes: 6 additions & 5 deletions src/components/navigation/CategoryNavigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@ import * as React from 'react';
import { useState } from 'react';

import { stylesheet } from '../../Stylesheet/stylesheet';
import { categoryFromCategoryConfig } from '../../config/categoryConfig';
import { useCategoriesConfig } from '../../config/useConfig';
import { useActiveCategoryScrollDetection } from '../../hooks/useActiveCategoryScrollDetection';
import useIsSearchMode from '../../hooks/useIsSearchMode';
import { useScrollCategoryIntoView } from '../../hooks/useScrollCategoryIntoView';
import { useShouldHideCustomEmojis } from '../../hooks/useShouldHideCustomEmojis';
import { isCustomCategory } from '../../typeRefinements/typeRefinements';
import { useCategoryNavigationRef } from '../context/ElementRefContext';

import { CategoryButton } from './CategoryButton';
Expand All @@ -33,13 +31,16 @@ export function CategoryNavigation() {
ref={CategoryNavigationRef}
>
{categoriesConfig.map(categoryConfig => {
const category = categoryFromCategoryConfig(categoryConfig);
const isActiveCategory = category === activeCategory;
const category = categoryConfig.category

if (isCustomCategory(categoryConfig) && hideCustomCategory) {
const isSkippedCustom = hideCustomCategory && category === 'custom'
if (isSkippedCustom) {
return null;
}

const isActiveCategory = category === activeCategory;


const allowNavigation = !isSearchMode && !isActiveCategory;

return (
Expand Down
105 changes: 46 additions & 59 deletions src/config/categoryConfig.ts
Original file line number Diff line number Diff line change
@@ -1,109 +1,96 @@
import { Categories, SuggestionMode } from '../types/exposedTypes';

export { Categories };

const categoriesOrdered: Categories[] = [
Categories.SUGGESTED,
Categories.CUSTOM,
Categories.SMILEYS_PEOPLE,
Categories.ANIMALS_NATURE,
Categories.FOOD_DRINK,
Categories.TRAVEL_PLACES,
Categories.ACTIVITIES,
Categories.OBJECTS,
Categories.SYMBOLS,
Categories.FLAGS
];
import { SuggestionMode } from '../types/public';

const CATEGORIES = [
'suggested',
'custom',
'smileys_people',
'animals_nature',
'food_drink',
'travel_places',
'activities',
'objects',
'symbols',
'flags'
] as const;

export type Category = typeof CATEGORIES[number];

export const SuggestedRecent: CategoryConfig = {
name: 'Recently Used',
category: Categories.SUGGESTED
};

export type CustomCategoryConfig = {
category: Categories.CUSTOM;
name: string;
category: 'suggested'
};

const configByCategory: Record<Categories, CategoryConfig> = {
[Categories.SUGGESTED]: {
category: Categories.SUGGESTED,
const configByCategory: Record<Category, CategoryConfig> = {
suggested: {
category: 'suggested',
name: 'Frequently Used'
},
[Categories.CUSTOM]: {
category: Categories.CUSTOM,
custom: {
category: 'custom',
name: 'Custom Emojis'
},
[Categories.SMILEYS_PEOPLE]: {
category: Categories.SMILEYS_PEOPLE,
smileys_people: {
category: 'smileys_people',
name: 'Smileys & People'
},
[Categories.ANIMALS_NATURE]: {
category: Categories.ANIMALS_NATURE,
animals_nature: {
category: 'animals_nature',
name: 'Animals & Nature'
},
[Categories.FOOD_DRINK]: {
category: Categories.FOOD_DRINK,
food_drink: {
category: 'food_drink',
name: 'Food & Drink'
},
[Categories.TRAVEL_PLACES]: {
category: Categories.TRAVEL_PLACES,
travel_places: {
category: 'travel_places',
name: 'Travel & Places'
},
[Categories.ACTIVITIES]: {
category: Categories.ACTIVITIES,
activities: {
category: 'activities',
name: 'Activities'
},
[Categories.OBJECTS]: {
category: Categories.OBJECTS,
objects: {
category: 'objects',
name: 'Objects'
},
[Categories.SYMBOLS]: {
category: Categories.SYMBOLS,
symbols: {
category: 'symbols',
name: 'Symbols'
},
[Categories.FLAGS]: {
category: Categories.FLAGS,
flags: {
category: 'flags',
name: 'Flags'
}
};

export function baseCategoriesConfig(
modifiers?: Record<Categories, CategoryConfig>
modifiers?: Record<Category, CategoryConfig>
): CategoriesConfig {
return categoriesOrdered.map(category => {
return CATEGORIES.map(category => {
return {
...configByCategory[category],
...(modifiers && modifiers[category] && modifiers[category])
};
});
}

export function categoryFromCategoryConfig(category: CategoryConfig) {
return category.category;
}

export function categoryNameFromCategoryConfig(category: CategoryConfig) {
return category.name;
}

export type CategoriesConfig = CategoryConfig[];

export type CategoryConfig = {
category: Categories;
category: Category;
name: string;
};

export type UserCategoryConfig = Array<Categories | CategoryConfig>;
export type UserCategoryConfig = Array<Category | CategoryConfig>;

export function mergeCategoriesConfig(
userCategoriesConfig: UserCategoryConfig = [],
modifiers: CategoryConfigModifiers = {}
): CategoriesConfig {
const extra = {} as Record<Categories, CategoryConfig>;
const extra = {} as Record<Category, CategoryConfig>;

if (modifiers.suggestionMode === SuggestionMode.RECENT) {
extra[Categories.SUGGESTED] = SuggestedRecent;
if (modifiers.suggestionMode === 'recent') {
extra['suggested'] = SuggestedRecent;
}

const base = baseCategoriesConfig(extra);
Expand All @@ -124,7 +111,7 @@ export function mergeCategoriesConfig(
}

function getBaseConfigByCategory(
category: Categories,
category: Category,
modifier: CategoryConfig = {} as CategoryConfig
) {
return Object.assign(configByCategory[category], modifier);
Expand Down
Loading