Handle (remove) zero-width-space #43
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…\x8b to an invalid sequence (FD BF BF BD A3 AC). We (chatgpt and I) added code to just remove these.
|
Hi, sorry for the delay. I'm not sure I understand the patch, you are saying there is a bug in the handling of zws somewhere else, so to work around it you get rid of all zws early on? Do you have a link or some other reproducer for the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently end up converting zero-width-space (zws) U+200B / \xe2\x8\x8b
to an invalid sequence (FD BF BF BD A3 AC). We (chatgpt and I) added code to just remove these, (in the same place that we swap the non-breaking space with space).