Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Load texture positions (and more) from JSON #4

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

FSMaxB
Copy link
Collaborator

@FSMaxB FSMaxB commented Jul 4, 2017

This is still a work in progress.

  • Make pairs of to_json, from_json for every struct
  • Use these to generate JSON
  • Hook up loading from JSON

@FSMaxB
Copy link
Collaborator Author

FSMaxB commented Jul 4, 2017

This stuff is quite prone to memory leaks, since it cannot be known which pointer points to a statically allocated resource and which at a dinamically allocated one.

But as long as the export and import aren't done too often, it should be fine.

@FSMaxB FSMaxB changed the title WIP: Load texture positions from JSON WIP: Load texture positions (and more) from JSON Jul 4, 2017
@FSMaxB
Copy link
Collaborator Author

FSMaxB commented Oct 22, 2017

Sorry for taking so long. I'm not sure when I am going to be able to continue with this.

@eXpl0it3r
Copy link
Owner

No worries, I haven't been able to really work on the project myself.

@eXpl0it3r eXpl0it3r closed this Oct 22, 2017
@eXpl0it3r eXpl0it3r changed the base branch from chore/refactor to master October 22, 2017 15:27
@eXpl0it3r
Copy link
Owner

This was not closed intentional, but it was auto-close because I merged the chore/refactor branch. I changed the target and reopened the PR. Make sure you pull the new master and rebase your branch onto master.

@eXpl0it3r
Copy link
Owner

Oh, hehe totally forgot that I added you as contributor and that you were working in a branch that I have control over as well... 😏
Thanks for updating!

@eXpl0it3r eXpl0it3r force-pushed the json-positions branch 2 times, most recently from ae914d2 to 93b7515 Compare December 16, 2018 14:17
@eXpl0it3r
Copy link
Owner

Finally gotten around to this again and added the importing steps, seems to work very well so far. Also updated nlohmann JSON to 3.4.0 (latest), in case you want to check it out yourself @FSMaxB 🙂

Next step is to think about, if we'll just remove the whole export and hard-coded init code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants