-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Load texture positions (and more) from JSON #4
base: master
Are you sure you want to change the base?
Conversation
This stuff is quite prone to memory leaks, since it cannot be known which pointer points to a statically allocated resource and which at a dinamically allocated one. But as long as the export and import aren't done too often, it should be fine. |
Sorry for taking so long. I'm not sure when I am going to be able to continue with this. |
No worries, I haven't been able to really work on the project myself. |
49ba133
to
7e4dadc
Compare
This was not closed intentional, but it was auto-close because I merged the chore/refactor branch. I changed the target and reopened the PR. Make sure you pull the new master and rebase your branch onto master. |
40fe397
to
6c5cb1f
Compare
Oh, hehe totally forgot that I added you as contributor and that you were working in a branch that I have control over as well... 😏 |
6c5cb1f
to
e64a997
Compare
ae914d2
to
93b7515
Compare
93b7515
to
eb71ccd
Compare
Finally gotten around to this again and added the importing steps, seems to work very well so far. Also updated nlohmann JSON to 3.4.0 (latest), in case you want to check it out yourself @FSMaxB 🙂 Next step is to think about, if we'll just remove the whole export and hard-coded init code... |
This is still a work in progress.
to_json
,from_json
for every struct