Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.expath.http.client:http-client-java from 1.4.1 to 1.5.2 #5346

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 2, 2024

Bumps org.expath.http.client:http-client-java from 1.4.1 to 1.5.2.

Commits
  • 2ad6067 [maven-release-plugin] prepare release http-client-1.5.2
  • 96bcc4d Update to newer tools-saxon
  • 5df1209 [bugfix] Fix an issue with setting headers in Post and Put responses
  • 926c697 [test] Further integration tests
  • acf3c1f [test] Start of adding some proper integration tests
  • 1975235 [maven-release-plugin] prepare for next development iteration
  • 46d78c6 [maven-release-plugin] prepare release http-client-1.5.1
  • 633729b Update to newer tools-saxon and pkg-saxon
  • 21b7511 [maven-release-plugin] prepare for next development iteration
  • 26c1baf [maven-release-plugin] prepare release http-client-1.5.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner July 2, 2024 03:16
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 2, 2024
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org:.expath.http.client:http-client-java v1.5.0 introduced a breaking change and is no longer compatible with exist-db

@reinhapa
Copy link
Member

@dependabot rebase

Bumps [org.expath.http.client:http-client-java](https://github.com/expath/expath-http-client-java) from 1.4.1 to 1.5.2.
- [Commits](expath/expath-http-client-java@http-client-1.4.1...http-client-1.5.2)

---
updated-dependencies:
- dependency-name: org.expath.http.client:http-client-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/org.expath.http.client-http-client-java-1.5.2 branch from 6aca954 to 60e5f73 Compare August 30, 2024 10:39
@dizzzz
Copy link
Member

dizzzz commented Aug 30, 2024

I remember that @adamretter stated that it is incompatible with develop. I guess before v7 we have to have a look, as I suspect an API change

@reinhapa
Copy link
Member

reinhapa commented Aug 30, 2024

@line-o as develop will end up being a major release I tried to just simply address the compile errors due to the API change...

@reinhapa reinhapa requested review from line-o and dizzzz August 31, 2024 15:38
@reinhapa
Copy link
Member

reinhapa commented Sep 1, 2024

org:.expath.http.client:http-client-java v1.5.0 introduced a breaking change and is no longer compatible with exist-db

@line-o I did all the needed changes now in order to have a successful compile for this next major version

@adamretter
Copy link
Member

@reinhapa If I recall there may also be dependency issues that are not compatible with eXist-db v7 at run time. You might want to just check that it works in practice too - I don't think there is much in the way of tests in eXist-db for that yet.

@reinhapa
Copy link
Member

reinhapa commented Sep 2, 2024

@reinhapa If I recall there may also be dependency issues that are not compatible with eXist-db v7 at run time. You might want to just check that it works in practice too - I don't think there is much in the way of tests in eXist-db for that yet.

@adamretter on what kind of tests do you suggest I should try on a local running instance in particular? I can try those outside the normal tests if you like...

@adamretter
Copy link
Member

Maybe just check some basic requests, and that XSLT with Saxon still works too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants