feat(ebay-donut-chart): implement donut chart with highcharts

[mikehobi]

Description

• Adds new module: ebay-donut-chart
• Adds new module: ebay-chart-legend

Context

Create a reusable donut chart based on DS Data Viz component design

Github ticket:

References

• Playbook
• Figma

Screenshots

[changeset-bot]

⚠️ No Changeset found

Latest commit: d18486e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[agliga]

Quick first look
Looks good. Lets try to get high charts uploaded to the CDN. Maybe we can setup some time to get that done.

[ianmcburnie]

@mikehobi Is the small version accounted for (with different layout)? I don't see it when running storybook.

[mikehobi]

@mikehobi Is the small version accounted for (with different layout)? I don't see it when running storybook.

@ianmcburnie I first assumed these were two "layout" types, but confirmed with Randy that these are breakpoint sizes, so narrowing the screen should show the small layout

[agliga]

Seems like theres no padding on these? Is that expected?

Also can we switch this to use the CDN version so that it doesn't block the site when loading?

[mikehobi]

Seems like theres no padding on these? Is that expected?
Also can we switch this to use the CDN version so that it doesn't block the site when loading?

• I believe there shouldn't be padding, and that would be handled by the user/grid setup
• Should be loading from CDN:

• I am only importing the type from "highcharts"

[agliga]

Overall looks good codewise.
will test it locally and merge it if it looks good.

[agliga]

Im approving for now
LGTM
Just fix the tests and we will try to get this in