TMBuilder v3.2.0 - support explicit null checks for nodes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s setter method return type (force adoption of builder pattern consistent with design of JPCheck classes).
…s regarding null checking ability.
shreyasmp
reviewed
Aug 17, 2023
| @@ -190,7 +203,9 @@ public void processJsonPath(String jsonPath, SoftAssert softAssert, DocumentCont | |||
| return; | |||
| } | |||
|
|
|||
| softAssert.assertNotNull(values, AssertMessageBuilder.build(jsonPath, "because the path does not exist.")); | |||
| if (!isNullExpected()) { | |||
There was a problem hiding this comment.
For collection types, is it worth adding another check empty as well for size ?
There was a problem hiding this comment.
Empty and size can both be evaluated by using the expected size check that already exists: https://github.com/eBay/NSTSuite/blob/main/NST/src/main/java/com/ebay/jsonpath/JPListOfIntegerCheck.java#L19 For the empty case size should be set to 0.
juliandesmarais
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request was made to define checks that verify nodes are null. v3.2.0 adds this support. Includes changes to JPChecks*, TMJPCheck* wrappers and all related unit tests.