Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save and load for shadowmap in index service #438

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shosseinimotlagh
Copy link
Contributor

No description provided.

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonYao287
Copy link
Contributor

JacksonYao287 commented Jun 6, 2024

pls update homestore version in conanfile before merging

@xiaoxichen
Copy link
Collaborator

@shosseinimotlagh can you quickly rebase this and merge as it was approved?

@zhiteng
Copy link

zhiteng commented Sep 28, 2024

Mehdi, checking again to see if we still want to land this.

@shosseinimotlagh
Copy link
Contributor Author

Mehdi, checking again to see if we still want to land this.

@zhiteng We need this for nublox 2.0 but it is p3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[varlen]save and load keys/values of shadow map for var node types
4 participants