- avail iteration count for convergence as an output dict parameter f… #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or 'bfsw' algorithm similar to 'nr'
vogt31337
approved these changes
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2502 +/- ##
===========================================
- Coverage 75.87% 75.87% -0.01%
===========================================
Files 284 284
Lines 33682 33681 -1
===========================================
- Hits 25556 25555 -1
Misses 8126 8126 ☔ View full report in Codecov by Sentry. |
|
@ajazHameed, thanks for the PR looks finde so far. I would accept it, but could you provide a changelog entry and maybe a simple test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the default 'nr' algorithm for power flow calculation, the number of iterations taken for the algorithm to converge is available as a parameter of pandapower network after running the power flow calculation. I have added the same parameter for 'bfsw' algorithm