add trafo/shunt characteristics and phase shifter logics #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panos-xenos
commented
Dec 12, 2024
•
panos-xenos
commented
- CGMES2pp converter: add trafo_characteristic_table & shunt__characteristic_table; amend trafo spline characteristic logic to use characteristic table; introduce shunt spline characteristics; amend/rename/introduce trafo/trafo3w/shunt parameters to reflect changes.
- Phase shifters: introduce different types of phase shifters for trafo and trafo3w; amend build_branch to reflect all changes.
- Pytests: amend/introduce pytests & corresponding libs/test network files to reflect changes above.
…ts for voltage_ratio & angle_deg
…s into the converter; move trafo & shunt spline characteristic creation out of the converter (old code commented)
…dex with id_characteristic_table; remove individual spline characteristic indices from trafo and shunt tables; create one row per trafo/shunt in trafo_characteristic_spline & shunt_characteristic_spline tables with all spline characteristic objects
…teristic_table to step_dependency_table
…p_step_degree with the values corresponding to the neutral tap position for PhaseTapChangerTabular trafos
# Conflicts: # pandapower/test/api/test_auxiliary.py
…cteristics_merge_trafocharactersitic # Conflicts: # pandapower/contingency/contingency.py
…cs_merge_trafocharactersitic merge trafo charactersitic
# Conflicts: # pandapower/create.py
…to feature/shunt-characteristics
@vogt31337 all required tests and pipelines are now passing, please consider this PR for pre-release 3.0 - many thanks! |
Ghanshyam-grid
force-pushed
the
feature/shunt-characteristics
branch
from
f528e81 to
d882ebf
Compare
# Conflicts: # CHANGELOG.rst # pandapower/create.py # pandapower/std_types.py
|
@mrifraunhofer please review our latest changes |
… side. 2) if machine has not attribute av_mode, continue with other.
…stics' into fork/JakobKirschner/feature/shunt-characteristics
…n tap_phase_shifter and tap_dependent_impedance
|
Hi @vogt31337, I have pushed some updates in create.py with deprecation messages to make it as backward compatible as possible. I also ensured that all json test files in old_version folder are not changed. Can you please review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.