add diagnostic function #537
Conversation
jkisse
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #537 +/- ##
===========================================
- Coverage 86.02% 83.70% -2.32%
===========================================
Files 90 91 +1
Lines 6497 6180 -317
===========================================
- Hits 5589 5173 -416
- Misses 908 1007 +99 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/pandapipes/diagnostic.py
| logger.info(f"If sinks and sources were scaled with a factor of to " | ||
| f"{check_scaling_factor}, the pipeflow would converge.") | ||
| else: | ||
| logger.warning(f"If sinks and sources were scaled with a factor of to " |
There was a problem hiding this comment.
You mean iterations as a function argument?
There was a problem hiding this comment.
I mean the pipeflow exception that must be caught. The else-part will never be reached.
| f"highest value in the net is {net.pipe.k_mm.max()}. Up to " | ||
| f"0.2 mm is a common value for old steel pipes." | ||
| f"\nRough pipes: {net.pipe.loc[net.pipe.k_mm > 0.5]}.") | ||
| net4 = net.deepcopy() |
There was a problem hiding this comment.
Is net.deepcopy() the same as copy.deepcopy(net)?
| branch_component = ["pipe", "valve", "compressor", "pump", "heat_exchanger", "circulation_pump"] | ||
| for bc in branch_component: | ||
| if hasattr(net, bc): | ||
| missing_f = np.setdiff1d(net[bc].from_junction, net.junction.index) |
There was a problem hiding this comment.
I would prefer the following:
- Add some code above that checks all tables in net and makes sure that the respective model is part of the component list (an important source of errors).
- Iterate over all branch components and use the "from_to_junction" identifiers to check the columns
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| import pandapipes.networks |
There was a problem hiding this comment.
I think, we should rather skip main calls
| @@ -615,3 +615,40 @@ def get_internal_tables_pandas(net, convert_types=True): | |||
| tbl[col] = tbl[col].astype(np.bool_) | |||
|
|
|||
| return node_table, branch_table | |||
|
|
|||
|
|
|||
| def print_pf_summary(net): | |||
There was a problem hiding this comment.
We would need some kwargs here (e.g. for heating grids)
There was a problem hiding this comment.
We could also just choose between different modes here. But for a start, we can also just add a hint that this function returns some unuseful stuff for heating grids.
Add diagnostic functions to run some common checks. The function is intended to be applied if a pipeflow calculation does not converge.
Please feel free to modify and extend the function!