Transient heat transfer wops #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to transient_heat_transfer_wops
…andapipes into transient_heat_transfer_wops
…ent test examples
…andapipes into transient_heat_transfer_wops
…andapipes into transient_heat_transfer_wops
# Conflicts: # pandapipes/component_models/abstract_models/branch_models.py # pandapipes/pipeflow.py
…ing if plotly is accessed without installation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## transient_heat_transfer #533 +/- ##
===========================================================
- Coverage 85.01% 78.84% -6.17%
===========================================================
Files 90 98 +8
Lines 6113 6945 +832
===========================================================
+ Hits 5197 5476 +279
- Misses 916 1469 +553
☔ View full report in Codecov by Sentry. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Daniel,
as this is my first pull request, I hope I have done it correctly. I deleted the files that we discussed and pushed the remaining changes, before sending this pull request. I can gladly support, if there are questions during the merge process.
I unchecked the box "Allow edits and access to secrets by maintainers", as I think this is not needed. Let me know, if I am mistaken. ;)
Thank you! Theda