Feature/circ pump branch model #517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable multiple creation of heat exchanger
# Conflicts: # CHANGELOG.rst
…up build system matrix
added 2 commits
February 8, 2023 23:24
- fixing slack equation position - adding a new relevant idx branch to identify circ pumps
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #517 +/- ##
===========================================
- Coverage 90.84% 85.08% -5.77%
===========================================
Files 139 90 -49
Lines 10996 6100 -4896
===========================================
- Hits 9989 5190 -4799
+ Misses 1007 910 -97 ☔ View full report in Codecov by Sentry. |
…branch_model # Conflicts: # pandapipes/component_models/abstract_models/branch_models.py # pandapipes/idx_branch.py # src/pandapipes/component_models/abstract_models/circulation_pump.py # src/pandapipes/component_models/circulation_pump_pressure_component.py # src/pandapipes/component_models/junction_component.py # src/pandapipes/idx_node.py # src/pandapipes/pf/build_system_matrix.py # src/pandapipes/toolbox.py
…_branch_model # Conflicts: # src/pandapipes/pipeflow.py # src/pandapipes/test/api/test_components/test_circ_pump_mass.py
- required test adaption to ensure test passing
- no mass creation in circ pumps - required test adaption to ensure test passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.