Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple_plotly function for pandapipes #430

Draft
wants to merge 93 commits into
base: develop
Choose a base branch
from
Draft

Conversation

jkisse
Copy link
Collaborator

@jkisse jkisse commented Nov 22, 2022

Like simple_plotly from pandapower but for pandapipes (interactive plotting function).
So far, only tested with gas grids.
Some components are still missing and the infofunction could be improved.
For every component, a create_..._trace function should be implemented. Different marker symbols can be used. Plotly provides a bunch of pre-defined symbols (listed here). If you have suggestions, which symbols are suitable for specific components, please let us know.

  • heat exchanger (marker: square-x)
  • compressor
  • valve (marker: bowtie)
  • different pump types
  • pressure regulator

Contributions welcome!

* only tested with gas grids

* some components are still missing (heat exchanger, compressor...)
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 86.82%. Comparing base (5eaa7d5) to head (eb5765e).
Report is 737 commits behind head on develop.

Files Patch % Lines
pandapipes/plotting/plotly/simple_plotly.py 0.00% 49 Missing ⚠️
pandapipes/plotting/plotly/traces.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #430      +/-   ##
===========================================
- Coverage    87.91%   86.82%   -1.09%     
===========================================
  Files           79       81       +2     
  Lines         4717     4776      +59     
===========================================
  Hits          4147     4147              
- Misses         570      629      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SimonRubenDrauz and others added 25 commits January 8, 2023 12:35
In file_io: do not pass object_hook to JSON Decoder in json.loads, but registry_class.

Please do not merge before pandapower has been updated to process this change! (cf. e2nIEE/pandapower#1827)
* For the test job, make sure that the repo is not checked out and the only available pandapipes installation is the one from pip

* Update the versions of the Actions

Co-authored-by: jkisse <[email protected]>
Hotfix for nx_graph creation of networks with flow controllers, as the keywords concerning them were not correctly considered within the function (include_flow_controls could not be set to False).
Flow control is considered in nx_graph creation
install Numba only for Python < 3.11
* enable multiple creation of heat exchanger

* adapted changelog and added doc for multiple heat exchanger
* add Python 3.11 to Release workflow
* change Python Version of docs_check and linting to 3.10
remove direct import from toolbox file
* remove Python 3.7 from test workflow

* update CHANGELOG.rst
@jkisse
Copy link
Collaborator Author

jkisse commented Apr 17, 2023

rename to simple_plotly_gas

- 2 function calls to connectivity check and pit reduction in case of "all" mode
- result extraction from active pit to pit done after both calculations separately
- all result extraction functions (also for all components) must consider that the connectivity lookups now differ between hydraulics and thermal calculation
sdrauz and others added 28 commits September 12, 2023 17:39
…pipes were considered. Adapted it accordingly that any branch component is considered.
calling 'calculate_derivatives_thermal' once
@jkisse
Copy link
Collaborator Author

jkisse commented Aug 6, 2024

Traces for compressors and valves added (as lines with dedicated colors)
simple_plotly extended respectively. Closed valves are represented as dotted lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants