Stratified thermal storage model #310
Open
+11,762
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and no other changes to pandapipes
…op correctly everywhere
…low and temperature spread the missing value is calculated. Changed variable names from _k to _c since temperatures are stored in °C. Added simulation results to .gitignore.
…, mass flow and circuit temperature which is to remain constant and which will be passed to the time step initialization functin are defined when initializing the object es a flag. Values of parameters and physical constant are adapted to the values used in parantapas model in order to assure comparibility
…ize_time_step - function in __init__. Raise warnings in functions to calculate mass flow or temperature spread if necessary.
…d order of strata in model. Set physical quantities to values defined in fmu model.
Codecov Report
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
- Coverage 89.10% 88.45% -0.65%
===========================================
Files 77 78 +1
Lines 4203 4358 +155
===========================================
+ Hits 3745 3855 +110
- Misses 458 503 +45
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a stratified thermal storage model plus test which isn't fit into the pandapipes structure yet.
@SimonRubenDrauz @dcronbach