feat: add snapshot peer registration and policy fields to proto#3307
feat: add snapshot peer registration and policy fields to proto#3307rguliyev wants to merge 2 commits into
Conversation
Adds SnapshotSourcePolicy (Create request) and SnapshotPeerRegistration (Pause response) plus their enums. Pure API-contract addition, no callers yet — orchestrator.pb.go regenerated via protoc, verified byte-identical to a fresh codegen run against this proto.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good — pure additive proto/codegen change with no callers yet.
Extended reasoning...
Overview
Adds two new proto messages/enums (SnapshotSourcePolicy on SandboxCreateRequest, SnapshotPeerRegistration on SandboxPauseResponse) plus their supporting enums, and the corresponding regenerated orchestrator.pb.go. Confirmed via grep that no Go code outside the generated file references these new types yet — this is a pure API-contract addition with zero behavioral wiring in this PR.
Security risks
None. No new code paths execute; the fields are inert until a future PR wires them into the orchestrator/API. New field numbers (4 on SandboxCreateRequest, 2 on SandboxPauseResponse) don't collide with existing ones, and enum zero values default sensibly (AUTO, UNSPECIFIED).
Level of scrutiny
Low. This is generated code plus a proto schema change with no logic to review — the correctness question is really "does the .pb.go match the .proto," which is externally verifiable (protoc-generated, and the diff shows consistent field/message-index renumbering throughout).
Other factors
The bug-hunting system found nothing, and the sole flagged candidate (ambiguous zero-value for SnapshotPeerFailureReason) was already checked by the finder/verifier pipeline and ruled out — not something I need to re-litigate. Since there are no callers, there's no runtime behavior to test.
1 participant
Adds SnapshotSourcePolicy (Create request) and SnapshotPeerRegistration (Pause response) plus their enums. Pure API-contract addition, no callers yet — orchestrator.pb.go regenerated via protoc, verified byte-identical to a fresh codegen run against this proto.