Skip to content

fix(storage): suppress SDK checksum WARN for S3-compatible backends (MinIO/Ceph) #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdaAibaby wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix(storage): suppress SDK checksum WARN for S3-compatible backends (MinIO/Ceph) #3284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/shared/pkg/storage/storage_aws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@ func newAWSStorage(ctx context.Context, spec Spec, limiter *limit.Limiter) (*aws
// default virtual-host style https://bucket.host/key) is required by
// most S3-compatible backends (MinIO, Ceph, …).
o.UsePathStyle = spec.UsePathStyle

// S3-compatible backends (MinIO, Ceph, etc.) do not return x-amz-checksum-*
// response headers. Without this setting the SDK logs a WARN for every
// GetObject response because it cannot validate the payload checksum.
// WhenRequired tells the SDK to only validate when the caller explicitly
// requested a checksum — matching the actual contract with these backends.
// Standard AWS S3 returns checksums and benefits from WhenSupported (the
// SDK default), so this opt-out is gated on UsePathStyle which already
// identifies S3-compatible deployments.
if spec.UsePathStyle {
o.ResponseChecksumValidation = aws.ResponseChecksumValidationWhenRequired
}
})
presignClient := s3.NewPresignClient(client)

Expand Down