Made Line Charts Better - #354
Merged
Merged
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
framework-tracker | 2c85a5f | Commit Preview URL Branch Preview URL |
Jul 25 2026, 05:02 AM |
Contributor
Deploying framework-tracker with
|
| Latest commit: |
2c85a5f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e464d42d.framework-tracker.pages.dev |
| Branch Preview URL: | https://line-charts.framework-tracker.pages.dev |
rdforte
reviewed
Jul 25, 2026
Comment on lines
+101
to
+109
| const latestChangeLabel = | ||
| latestChange == null | ||
| ? null | ||
| : latestChange === 0 | ||
| ? 'No change' | ||
| : `${latestChange > 0 ? '+' : '−'}${formatChartValue( | ||
| Math.abs(latestChange), | ||
| valueFormat, | ||
| )}` |
Collaborator
There was a problem hiding this comment.
nit double ternaries always hurt readability and my eyeballs
Collaborator
Author
There was a problem hiding this comment.
I thought you might say that. I can change it.
rdforte
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved line charts designs and added change from last version. Also added tables for screen readers
